Skip to content

Get name from object #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2024
Merged

Get name from object #76

merged 6 commits into from
Oct 25, 2024

Conversation

vlasovsoft1979
Copy link
Contributor

@vlasovsoft1979 vlasovsoft1979 commented Sep 25, 2024 •
edited
Loading

For example, store Image ColorSpace in the separate object:

8 0 obj
<<
/Type /XObject
/Subtype /Image
/ColorSpace 10 0 R
>>
...
10 0 obj
/DeviceRGB
endobj

michaelrsweet
michaelrsweet requested changes Sep 25, 2024
View reviewed changes
Copy link
Owner

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on the addition to the header. Also, if we have a getter we should have a way to create a name object (pdfioFileCreateNameObj).

pdfio.h Outdated
extern pdfio_stream_t *pdfioObjCreateStream(pdfio_obj_t *obj, pdfio_filter_t compression) _PDFIO_PUBLIC;
extern pdfio_array_t *pdfioObjGetArray(pdfio_obj_t *obj) _PDFIO_PUBLIC;
extern pdfio_dict_t *pdfioObjGetDict(pdfio_obj_t *obj) _PDFIO_PUBLIC;
extern const char *pdfioObjGetName(pdfio_obj_t *obj) _PDFIO_PUBLIC;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab between "const char" and "*pdfioObjGetName". Also, please move this down between ...GetLength and ...GetNumber so it is sorted alphabetically.

@michaelrsweet michaelrsweet added this to the Future milestone Sep 25, 2024
@michaelrsweet michaelrsweet added enhancement New feature or request priority-low labels Sep 25, 2024
@michaelrsweet michaelrsweet self-assigned this Sep 25, 2024
@vlasovsoft1979 vlasovsoft1979 changed the title Get name from object. For example, store Image ColorSpace in the separate object. Get name from object Sep 25, 2024
@vlasovsoft1979
Copy link
Contributor Author

@michaelrsweet
This is my first PR to github. Please let me know if I forget something. I've fixed your comments. Now it's your turn.

michaelrsweet
michaelrsweet requested changes Sep 27, 2024
View reviewed changes
Copy link
Owner

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, see comment. And thank you!

pdfio-object.c Outdated
}


//
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, please move this later in the file before pdfioObjGetNumber.

@michaelrsweet
Copy link
Owner

OK, holding for the next feature release (have a bug fix release to do first...)

@michaelrsweet michaelrsweet merged commit 0e45e49 into michaelrsweet:master Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelrsweet michaelrsweet michaelrsweet approved these changes

Assignees

@michaelrsweet michaelrsweet

Labels

enhancement New feature or request priority-low

Projects

None yet

Milestone

Future

Development

Successfully merging this pull request may close these issues.

2 participants

@vlasovsoft1979 @michaelrsweet