Skip to content

FIX: re-add mx_server_is_in?(domain_list) for backwards compatibility #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

phoet
Copy link
Collaborator

@phoet phoet commented Mar 1, 2025

@nijikon could you use this branch and check if that works as expected?

@nijikon
Copy link

nijikon commented Mar 1, 2025

@phoet I don't think we need to re-add it, but you decide. I would update the docs and include a note about the change in the CHANGELOG.

allow_any_instance_of(ValidEmail2::Address).to receive_messages(valid_mx?: true, valid_strict_mx?: true, disposable_mx_server?: false)

@phoet
Copy link
Collaborator Author

phoet commented Mar 1, 2025

putting it back in place is the sensible thing to do. i would not touch the docs for now as it's likely going to change soon again.

@nijikon
Copy link

nijikon commented Mar 1, 2025

@phoet Sounds good. I can confirm that it works as expected with these changes.

@phoet
Copy link
Collaborator Author

phoet commented Mar 1, 2025

great, i can test if our automated release workflow is back on track!

@phoet phoet merged commit 5b0f979 into main Mar 1, 2025
16 checks passed
@phoet phoet deleted the re_add_missing_stub branch March 1, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants