fixed crush on rotation change when displaying action dialog

mickey946 · Mar 16, 2014 · ccabf51 · ccabf51
1 parent 3a171d6
commit ccabf51
Show file tree

Hide file tree

Showing 11 changed files with 18 additions and 10 deletions.
diff --git a/TodoListManager/bin/TodoListManager.apk b/TodoListManager/bin/TodoListManager.apk
diff --git a/TodoListManager/bin/classes.dex b/TodoListManager/bin/classes.dex
diff --git a/TodoListManager/bin/classes/il/ac/huji/todolist/ActionTaskDialog$1.class b/TodoListManager/bin/classes/il/ac/huji/todolist/ActionTaskDialog$1.class
diff --git a/TodoListManager/bin/classes/il/ac/huji/todolist/ActionTaskDialog$2.class b/TodoListManager/bin/classes/il/ac/huji/todolist/ActionTaskDialog$2.class
diff --git a/TodoListManager/bin/classes/il/ac/huji/todolist/ActionTaskDialog.class b/TodoListManager/bin/classes/il/ac/huji/todolist/ActionTaskDialog.class
diff --git a/TodoListManager/bin/classes/il/ac/huji/todolist/TodoListManagerActivity$1.class b/TodoListManager/bin/classes/il/ac/huji/todolist/TodoListManagerActivity$1.class
diff --git a/TodoListManager/bin/classes/il/ac/huji/todolist/TodoListManagerActivity.class b/TodoListManager/bin/classes/il/ac/huji/todolist/TodoListManagerActivity.class
diff --git a/TodoListManager/bin/resources.ap_ b/TodoListManager/bin/resources.ap_
diff --git a/TodoListManager/res/layout/activity_add_new_todo_item.xml b/TodoListManager/res/layout/activity_add_new_todo_item.xml
@@ -22,7 +22,7 @@
         android:layout_marginBottom="@dimen/activity_vertical_margin"
         android:layout_marginLeft="@dimen/activity_horizontal_margin"
         android:layout_marginRight="@dimen/activity_horizontal_margin" />
-    
+
     <View
         android:layout_width="fill_parent"
         android:layout_height="1dp"
@@ -43,7 +43,7 @@
             android:id="@+id/btnCancel"
             style="?android:attr/buttonBarButtonStyle"
             android:layout_width="0dip"
-            android:layout_height="wrap_content"
+            android:layout_height="fill_parent"
             android:layout_weight="1"
             android:onClick="cancel"
             android:text="@string/dialog_cancel_button" />
@@ -52,7 +52,7 @@
             android:id="@+id/btnOK"
             style="?android:attr/buttonBarButtonStyle"
             android:layout_width="0dip"
-            android:layout_height="wrap_content"
+            android:layout_height="fill_parent"
             android:layout_weight="1"
             android:onClick="add"
             android:text="@string/action_add_todo_task" />

diff --git a/TodoListManager/src/il/ac/huji/todolist/ActionTaskDialog.java b/TodoListManager/src/il/ac/huji/todolist/ActionTaskDialog.java
@@ -11,7 +11,6 @@
 import android.content.Intent;
 import android.net.Uri;
 import android.os.Bundle;
-import android.util.Log;
 import android.widget.ListAdapter;
 
 /**
@@ -33,6 +32,8 @@ public ActionTaskDialog(int pos, String task) {
 		super();
 		_pos = pos;
 		_task = task;
+
+		setRetainInstance(true);
 	}
 
 	public int getPos() {
@@ -106,6 +107,13 @@ public void onClick(DialogInterface dialog, int id) {
 		// Create the AlertDialog object and return it
 		return builder.create();
 	}
+
+	@Override
+	public void onDestroyView() {
+		if (getDialog() != null && getRetainInstance())
+			getDialog().setDismissMessage(null);
+		super.onDestroyView();
+	}
 }
 
 
diff --git a/TodoListManager/src/il/ac/huji/todolist/TodoListManagerActivity.java b/TodoListManager/src/il/ac/huji/todolist/TodoListManagerActivity.java
@@ -30,10 +30,10 @@
 public class TodoListManagerActivity extends Activity implements DeleteTaskDialogListener {
 
 	private RetainedFragment<ArrayList<Pair<String, Long>>> _dataFragment;
-
-	ArrayAdapter<Pair<String, Long>> _adapter;
-	ArrayList<Pair<String, Long>> _listItems;//= new ArrayList<Pair<String, Long>>();
-
+	private ArrayAdapter<Pair<String, Long>> _adapter;
+	private ArrayList<Pair<String, Long>> _listItems;
+
+	private ActionTaskDialog _actionTaskDialog;
 
 	@Override
 	protected void onCreate(Bundle savedInstanceState) {
@@ -66,8 +66,8 @@ protected void onCreate(Bundle savedInstanceState) {
 			@TargetApi(Build.VERSION_CODES.HONEYCOMB)
 			@SuppressLint("NewApi")
 			public boolean onItemLongClick(AdapterView<?> parent, View child, int pos, long id) {
-				ActionTaskDialog actionTaskDialog = new ActionTaskDialog(pos, _listItems.get(pos).first);
-				actionTaskDialog.show(getFragmentManager(), "actionTask");
+				_actionTaskDialog = new ActionTaskDialog(pos, _listItems.get(pos).first);
+				_actionTaskDialog.show(getFragmentManager(), "actionTask");
 				return true;
 			}
 		});