Skip to content

Conversation

@rhudea
Copy link

@rhudea rhudea commented Mar 4, 2020

No description provided.

@ljnelson
Copy link
Member

ljnelson commented Mar 5, 2020

This looks OK to me, although there are always massive changes that are also needed in the Tiller installation area of the code if I remember right. Have you taken a look at those? Otherwise users will install the wrong version of Tiller and will not be able to specify the same options.

Copy link

@gewei2000 gewei2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants