-
-
Notifications
You must be signed in to change notification settings - Fork 23
Enhance Linting Rules: Add Prettier, Stylelint, and Stricter ESLint Configurations #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lbroudoux the usage of the pplancq packages has been well received, based on the feedback I’ve received. This one offers the flexibility to customize as needed without any issues. The overall rules are appreciated, and even in the event of a shift in direction, they can still be adapted or reused easily (copy). |
About Husky, I use in dotnet implementation (dotnet husky) but it's the same. |
I like consistency and helping maintainability so it's a +1 here! I have one additional feature request, though: could we also ensure that files containing code (TS, TSX or JS here) contain the regular copyright header? The model we have for Java files is:
|
Thanks for your feedback! |
I've set up Husky to introduce Git hooks for better control during development:
To make this work properly, I updated the Eventually, the server will also be integrated into the workspace. You might also notice a Lastly, I updated the installation instructions for the new frontend in the I hope these changes are helpful and align with what you were expecting! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is globally OK for me but I'm concerned about integrating dependencies on @pplancq
packages: not about the quality of your work but about license compatibility issues and real need of non main stream deps.
Could you provide more explanations on these whilst I check if the license is actually an issue?
…atting Signed-off-by: Paul PLANCQ <paul.plancq@outlook.fr>
Signed-off-by: Paul PLANCQ <paul.plancq@outlook.fr>
Signed-off-by: Paul PLANCQ <paul.plancq@outlook.fr>
…tend Signed-off-by: Paul PLANCQ <paul.plancq@outlook.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
@pplancq
), but if you prefer, I can manually add all the configuration files instead.I was also considering setting up Husky, a tool that allows you to add Git hooks in order to enforce code linting at commit time. I would like to know your opinion on this subject to see if I can integrate it into the project.
Related issue(s)
N/A