Skip to content

chore: Removed some unncessary null checks from 'test.go' #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

Harsh4902
Copy link

Description

  • This PR removes some unnecessary null checks and unused timeUnitChoice map from test.go file.

Related issue(s)

@Harsh4902
Copy link
Author

@lbroudoux Please don't merge it. I am still doing some cleanup work.

@Harsh4902
Copy link
Author

@lbroudoux Now it's done.

@lbroudoux lbroudoux added this to the 1.0.0 milestone Mar 21, 2025
@lbroudoux lbroudoux added the kind/task Project maintenance task label Mar 21, 2025
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbroudoux lbroudoux merged commit 1a3de0f into microcks:1.x Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Project maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants