Refactor type lowering for local RWStructuredBuffers #5457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To handle a local RWStructuredBuffers, we treat the local varible like a pointer to the global variable. This is needed to properly represent the semantics of these local variables. The difficulty is that this spread out in a number of places creating special cases are not always intuiative. It is also causing problems for arrays of RWStructuredBuffers. This change will modify the type of the local variable generated by the spirv emitter to be a pointer instead of waiting for type lowering to handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle a local RWStructuredBuffers, we treat the local varible like a
pointer to the global variable. This is needed to properly represent the
semantics of these local variables. The difficulty is that this spread
out in a number of places creating special cases are not always
intuiative. It is also causing problems for arrays of
RWStructuredBuffers.
This change will modify the type of the local variable generated by the
spirv emitter to be a pointer instead of waiting for type lowering to
handle it.