spirv: stop emitting ImageMSArray capability #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capability trimming pass is handling this logic now. Needed to fix a test as DCE now runs. ImageMSArray is also not required for this test as no OpImageType has array=1, ms=1 and sampled=2. Signed-off-by: Nathan Gauër <[email protected]>
s-perron
approved these changes
Sep 6, 2023
|
Can you add a test that does require |
Yeah, I wanted to do that, but haven't found how. I'll try a bit more, but seems every HLSL code I wrote doesn't have the |
remove ImageMsArray capability
Keenuts
changed the title
|
Removed the capability, and fixed the documentation. |
s-perron
approved these changes
Sep 8, 2023
sudonatalie
approved these changes
Sep 8, 2023
|
Arf auto-merge |
|
Let me fix that in another PR |
ShchchowAMD
pushed a commit
to ShchchowAMD/DirectXShaderCompiler
that referenced
this pull request
Sep 11, 2023
ImageMSArray is only required is OpTypeImage arrayed=1, MS=1 and sampled=2. This is never the case AFAIK for code emitted from HLSL. No tests or shaders I knew about required it, so should be OK removing it from DXC. --------- Signed-off-by: Nathan Gauër <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageMSArray is only required is OpTypeImage arrayed=1, MS=1 and sampled=2. This is never the case AFAIK for code emitted from HLSL. No tests or shaders I knew about required it, so should be OK removing it from DXC.