Add outputs to the IDxcResult when linking #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hash to the output. Improvements to linker result, adding reflection and hash to the output.
python3kgae
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the IDxcLinker::Link api to return outputs via the
IDxcResult interface. We now support getting the following outputs from the
IDxcResult returned from the call to Link
DXC_OUT_REFLECTION
DXC_OUT_SHADER_HASH
DXC_OUT_ERRORS
DXC_OUT_ROOT_SIGNATURE
Additionally, the DXC_OUT_OBJECT output will now set its name based on the
/Focommand line flag.
This makes the api more consistent with the Compile output and makes it easier
to access these outputs without having to crack open the dxil container.
Original patch by @tex3d. Tests added by @dmpots.