Fix build on ARM with non-VS generator #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_GENERATOR_PLATFORM is not widely available. For example, Ninja generator doesn't define it. Use CMAKE_C_COMPILER_ARCHITECTURE_ID to avoid this problem.
python3kgae
approved these changes
Sep 19, 2023
llvm-beanz
pushed a commit
to llvm-beanz/DirectXShaderCompiler
that referenced
this pull request
Sep 21, 2023
CMAKE_GENERATOR_PLATFORM is not widely available. For example, Ninja generator doesn't define it. Use CMAKE_C_COMPILER_ARCHITECTURE_ID to avoid this problem.
gongminmin
added a commit
to gongminmin/DirectXShaderCompiler
that referenced
this pull request
Jan 14, 2024
CMAKE_GENERATOR_PLATFORM is not widely available. For example, Ninja generator doesn't define it. Use CMAKE_C_COMPILER_ARCHITECTURE_ID to avoid this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_GENERATOR_PLATFORM is not widely available. For example, Ninja generator doesn't define it. Use CMAKE_C_COMPILER_ARCHITECTURE_ID to avoid this problem.