Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps for release #6929

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Update deps for release #6929

merged 2 commits into from
Sep 24, 2024

Conversation

cassiebeckley
Copy link
Collaborator

No description provided.

@cassiebeckley cassiebeckley requested a review from a team as a code owner September 23, 2024 23:32
@cassiebeckley
Copy link
Collaborator Author

The ComputeDerivativeGroup*NV capabilities and DerivativeGroup*NV execution modes are now being called ComputeDerivateGroup*KHR and DerivativeGroup*KHR by the SPIRV-Tools disassembler. More work will need to be done to properly support the SPV_KHR_compute_shader_derivatives extension, but to unblock the release I've simply updated the tests to check for the new names.

dneto0
dneto0 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cassiebeckley cassiebeckley merged commit d9a5e97 into microsoft:main Sep 24, 2024
12 checks passed
@cassiebeckley cassiebeckley deleted the v2024.4.rc1-update-deps branch September 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-perron s-perron s-perron approved these changes

@dneto0 dneto0 dneto0 approved these changes

@Keenuts Keenuts Awaiting requested review from Keenuts

Assignees
No one assigned
Labels
None yet
Projects
HLSL Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cassiebeckley @dneto0 @s-perron