[SPIR-V] Allow built-in object types as arguments to SpirvType #6951
Conversation
There has been a validation error for passing in a built-in type to a template since the first commit to DXC. This check exists to prevent instances like this: ``` Texture2D<SamplerState> image; ``` When DXC was first created, users could not create their own templates, and therefore having a generic check for this did not cause any problems. However, now that HLSL 2021 allows users to create their own templates, and inline SPIR-V lets users pass types in to the SpirvType and SpirvOpaqueType templates in order to reference them, this is causing problems. This PR allows the SpirvType and SpirvOpaqueType templates to take HLSL built-in types as arguments. Fixes microsoft#6498
There was a problem hiding this comment.
I think we need to have some discussion about this.
Texture types should really only take scalar or vectors. The fact that they ever allowed anything else is a bug.
They do actually work with template objects today (see: https://godbolt.org/z/zPq1T4q3b). The change you're making here allows them to work with HLSL's built-in objects (resources and the like), which absolutely should not be supported.
I'd like to understand better the case where these types should be allowed so that we can better craft language rules around them.
|
For me it would just be enough to allow Stuffing SpirTypes into HLSL templates is probably a road to many bugs, and the most important feature is being able to build SpirvTypes from Native and SpirV Types because that way we can build any type we want/need. |
This should be be allowing more type as templates into the standard Texture types. If it does, that is unintentional. We want to allow more types as templates to the However, we should still be able to use a SpirvType as a template to a SpirvType: https://godbolt.org/z/Pqh6nYchf. |
There has been a validation error for passing in a built-in type to a template since the first commit to DXC. This check exists to prevent instances like this:
When DXC was first created, users could not create their own templates, and therefore having a generic check for this did not cause any problems. However, now that HLSL 2021 allows users to create their own templates, and inline SPIR-V lets users pass types in to the
SpirvTypeandSpirvOpaqueTypetemplates in order to reference them, this is causing problems.This PR allows the
SpirvTypeandSpirvOpaqueTypetemplates to take HLSL built-in types as arguments.Fixes #6498