Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V] Allow built-in object types as arguments to SpirvType #6951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SPIR-V] Allow built-in object types as arguments to SpirvType #6951

wants to merge 1 commit into from

Commits on Oct 8, 2024

  1. [SPIR-V] Allow built-in object types as arguments to SpirvType 

    There has been a validation error for passing in a built-in type to a
template since the first commit to DXC. This check exists to prevent
instances like this:

```
Texture2D<SamplerState> image;
```

When DXC was first created, users could not create their own templates,
and therefore having a generic check for this did not cause any
problems. However, now that HLSL 2021 allows users to create their own
templates, and inline SPIR-V lets users pass types in to the SpirvType
and SpirvOpaqueType templates in order to reference them, this is
causing problems.

This PR allows the SpirvType and SpirvOpaqueType templates to take
HLSL built-in types as arguments.

Fixes microsoft#6498
    @cassiebeckley
    cassiebeckley committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7d2702d View commit details
    Browse the repository at this point in the history