[SPIR-V] Handle vectors passed to asuint #6953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s-perron lmk if this approach looks correct to you. If it does, I think I'll need to update dead code elimination again, since the case where a temporary variable is being used is having the |
s-perron
reviewed
Oct 10, 2024
`asuint` should be able to take vectors in addition to scalar values. Previously, it would be lowered as a bitcast from the input value to a vector of uints with a width of 2, which is not large enough if the input value is larger than a scalar value. In order to handle, for example, an input value that is a `double4`, we instead perform a component-wise bitcast. Fixes microsoft#6735
cassiebeckley
force-pushed
the
asuint-vector
branch
from
5961b83
to
7f4a6cd
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
cassiebeckley
force-pushed
the
asuint-vector
branch
from
7f4a6cd
to
6f5e5dd
Compare
s-perron
reviewed
Oct 15, 2024
s-perron
approved these changes
Oct 16, 2024
Keenuts
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asuintshould be able to take vectors in addition to scalar values. Previously, it would be lowered as a bitcast from the input value to a vector of uints with a width of 2, which is not large enough if the input value is larger than a scalar value. In order to handle, for example, an input value that is adouble4, we instead perform a component-wise bitcast.Fixes #6735