[SPIRV] Round the stride to be a multiple of the alignment. #6967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently pick the size of a struct to be the stride of the array elements when doing scalar layout. This is not correct because this could cause the struct to not be correctly aligned. This is fixed by rounding the size of the struct up to a mutliple of the alignment. Fixes microsoft#6947
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
cassiebeckley
approved these changes
Oct 15, 2024
Keenuts
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pick the size of a struct to be the stride of the array
elements when doing scalar layout. This is not correct because this
could cause the struct to not be correctly aligned.
This is fixed by rounding the size of the struct up to a mutliple of the
alignment.
Fixes #6947