Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V] Fix cast elision with initializer lists #6992

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[SPIR-V] Fix cast elision with initializer lists #6992

merged 1 commit into from
Nov 1, 2024

Commits on Oct 30, 2024

  1. [SPIR-V] Fix cast elision with initializer lists 

    When an a chain of casts were performed in an initializer list,
only the source and destination types were considered.
This means float -> uint was the same as float -> int -> uint.
This however is not correct: intermediate casts can change the result.

Removing the shortcut we took solves this issue.

Fixes microsoft#6975

Signed-off-by: Nathan Gauër <[email protected]>
    @Keenuts
    Keenuts committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5d0ac68 View commit details
    Browse the repository at this point in the history