Make LongVectors tests run as part of standard test passes#7873
Make LongVectors tests run as part of standard test passes#7873damyanp merged 2 commits intomicrosoft:mainfrom
Conversation
Currently, the various test runners (lit, hcttest.cmd) only run execution tests where the Priority metadata is <2. Previously, the LongVectors tests didn't set a value for priority, and this resulted in them never being selected. This change adds the missing priority metadata - and then fixes up the tests so they don't immediately fail if the runtime/device doesn't support SM 6.9!
Co-authored-by: Alex Sepkowski <alexsepkowski@gmail.com>
| TEST_CLASS_PROPERTY( | ||
| "Kits.Specification", | ||
| "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement") | ||
| TEST_METHOD_PROPERTY(L"Priority", L"0") |
There was a problem hiding this comment.
Hmm, actually wondering if this is right? I tested it seems to work as I would expect. The individual methods all seem to inherit it. But seeing a TEST_METHOD_PROPERTY inside of the TEST_CLASS definition seems weird.
Did you sanity check that? Wondering if this behavior could change in the future.
There was a problem hiding this comment.
I take that back. It shouldn't compile if it isnt expected to work.
There was a problem hiding this comment.
Yeah, it looks weird, but this is how it's done in ExecutionTest.cpp. I'm not sure you'd expect a compilation error due to the way TAEF is implemented, but a runtime error maybe. Practically, it seems to apply the same property to all the methods in the class.
|
/azp run (Double checking nothing else changed recently!) |
|
Command 'run
(Double' is not supported by Azure Pipelines.
See additional documentation. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
Currently, the various test runners (lit, hcttest.cmd) only run execution tests where the Priority metadata is <2.
Previously, the LongVectors tests didn't set a value for priority, and this resulted in them never being selected. This change adds the missing priority metadata - and then fixes up the tests so they don't immediately fail if the runtime/device doesn't support SM 6.9!