Make LongVectors tests run as part of standard test passes #7873
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the various test runners (lit, hcttest.cmd) only run execution tests where the Priority metadata is <2. Previously, the LongVectors tests didn't set a value for priority, and this resulted in them never being selected. This change adds the missing priority metadata - and then fixes up the tests so they don't immediately fail if the runtime/device doesn't support SM 6.9!
alsepkow
reviewed
Nov 5, 2025
Co-authored-by: Alex Sepkowski <[email protected]>
spall
approved these changes
Nov 6, 2025
alsepkow
reviewed
Nov 6, 2025
| TEST_CLASS_PROPERTY( | ||
| "Kits.Specification", | ||
| "Device.Graphics.D3D12.DXILCore.ShaderModel69.CoreRequirement") | ||
| TEST_METHOD_PROPERTY(L"Priority", L"0") |
There was a problem hiding this comment.
Hmm, actually wondering if this is right? I tested it seems to work as I would expect. The individual methods all seem to inherit it. But seeing a TEST_METHOD_PROPERTY inside of the TEST_CLASS definition seems weird.
Did you sanity check that? Wondering if this behavior could change in the future.
There was a problem hiding this comment.
I take that back. It shouldn't compile if it isnt expected to work.
There was a problem hiding this comment.
Yeah, it looks weird, but this is how it's done in ExecutionTest.cpp. I'm not sure you'd expect a compilation error due to the way TAEF is implemented, but a runtime error maybe. Practically, it seems to apply the same property to all the methods in the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the various test runners (lit, hcttest.cmd) only run execution tests where the Priority metadata is <2.
Previously, the LongVectors tests didn't set a value for priority, and this resulted in them never being selected. This change adds the missing priority metadata - and then fixes up the tests so they don't immediately fail if the runtime/device doesn't support SM 6.9!