Skip to content

Conversation

@alsepkow
Copy link
Contributor

@alsepkow alsepkow commented Nov 5, 2025

Adds the basic framework for WaveActiveOp tests and the test cases for WaveActiveSum.
This partially addresses #7472
WARP requires an update for this test to pass so this test will not run in automation for now (no priority set in TAEF metadata).

@damyanp
Copy link
Member

damyanp commented Nov 6, 2025

WARP requires an update for this test to pass so this test will not run in automation for now

You should explicitly mark these tests as priority 2 to prevent them from running, since we'll be setting the default for all the tests in the class to pri 0.

@alsepkow
Copy link
Contributor Author

alsepkow commented Nov 6, 2025 via email

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some uncontroversial names that just need to be fixed and a suggestion for a simpler type for a string.

Otherwise LGTM.

@github-project-automation github-project-automation bot moved this from New to In progress in HLSL Roadmap Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@alsepkow alsepkow requested a review from damyanp November 6, 2025 21:46
Copy link
Collaborator

@joaosaffran joaosaffran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some merges need to be cleaned, other than that LGTM

Copy link
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I expect this'll LGTM once the compilation errors are fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants