Skip to content

Update return by value threshold in gsl::not_null #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

ozaktash
Copy link
Contributor

@ozaktash ozaktash commented May 4, 2025

Fixes: #1204

  • Allow returning by value for types that are not greater than two pointers in size

- Allow returning by value for types that are not greater than two pointers in size
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • include/gsl/pointers: Language not supported

@carsonRadtke carsonRadtke moved this from Open to Ready for Review in Microsoft/GSL Pull Requests In-Flight May 6, 2025
@carsonRadtke carsonRadtke added Type: Enhancement Suggests an improvement or new feature Status: Review Needed Needs review from GSL maintainers labels May 6, 2025
@carsonRadtke
Copy link
Collaborator

Thanks for identifying this issue and posting a fix!

@carsonRadtke carsonRadtke merged commit 466e4eb into microsoft:main May 12, 2025
83 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Merged in Microsoft/GSL Pull Requests In-Flight May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed Needs review from GSL maintainers Type: Enhancement Suggests an improvement or new feature
Projects
Development

Successfully merging this pull request may close these issues.

gsl::not_null should allow returning by value for the types whose size equals to the size of two pointers
2 participants