Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] extend delegate parameter validators with validators from source parameter. #6832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jan 27, 2025

Add validators from source parameter to delegate parameter. Alternative to #6817

@jenshnielsen jenshnielsen requested a review from a team as a code owner January 27, 2025 12:21
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (29f4942) to head (a073131).
Report is 37 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6832   +/-   ##
=======================================
  Coverage   69.37%   69.38%           
=======================================
  Files         340      341    +1     
  Lines       31341    31355   +14     
=======================================
+ Hits        21744    21755   +11     
- Misses       9597     9600    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

esbenborkhansen and others added 2 commits January 27, 2025 14:17
This will ensure that when the validator is used to find the datatype of a parameter it can be detected correctly
@jenshnielsen jenshnielsen changed the title [wip] extend test_value_validation to cover more cases [wip] extend delegate parameter validators with validators from source parameter. Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants