Conversation
In this PR we add a new Grammar File and Parser specifically targeting Fabric DW platform. Currently we use TSql160 grammar and parser and hence we have simply cloned them in this PR before adding any changes in subsequent iterations. This would help in the development of a few features in Fabric DW DMS team. **Our PM Specs for these features**: [DacFx & ScriptDom support CI/CD in Fabric Web and Client Tools](https://microsoft-my.sharepoint.com/:w:/p/salilkanade/ES9gX3CH06xKmMny3fgr0r4BAjKCObgS3lCJ9qf97q8y6A?e=h76P3r&ovuser=72f988bf-86f1-41af-91ab-2d7cd011db47%2Cdhrelwan%40microsoft.com) [DacFx integration for Fabric DW CI/CD](https://microsoft-my.sharepoint.com/:w:/p/salilkanade/ES9gX3CH06xKmMny3fgr0r4BAjKCObgS3lCJ9qf97q8y6A?e=h76P3r&ovuser=72f988bf-86f1-41af-91ab-2d7cd011db47%2Cdhrelwan%40microsoft.com) **Fabric DW Contacts**: Dev: @<Dhruv Relwani> EM: @<Don Reamey> PM: @<Pradeep Srikakolapu> Related work items: #4093147
Adding new Event types with 170 ---- #### AI description (iteration 1) #### PR Classification New feature #### PR Summary This pull request adds new event types to the `EventNotificationEventType` enumeration. - `EventNotificationEventType.cs`: Added `AddInformationProtection` and `DropInformationProtection` event types. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Adding tests for scalar function support for the newly added TSqlFabricDW parser. Related work items: #4161090
zijchen
approved these changes
May 23, 2025
# Pull Request Template for ScriptDom ## Description Adding release notes for 170.0.44.0 Before submitting your pull request, please ensure you have completed the following: ## Code Change - [ ] The [Common checklist](https://msdata.visualstudio.com/SQLToolsAndLibraries/_git/Common?path=/Templates/PR%20Checklist%20for%20SQLToolsAndLibraries.md&version=GBmain&_a=preview) has been reviewed and followed - [ ] Code changes are accompanied by appropriate unit tests - [ ] Identified and included SMEs needed to review code changes - [ ] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=make-the-changes-in) here to make changes in the code ## Testing - [ ] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=to-extend-the-tests-do-the-following%3A) here to add new tests for your feature ## Documentation - [ ] Update relevant documentation in the [wiki](https://dev.azure.com/msdata/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki) and the README.md file ## Additional Information Please provide any additional information that might be helpful for the reviewers Adding release notes for 170.0.44.0
zijchen
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a detailed description. Be as descriptive as possible - include information about what is being changed,
why it's being changed, and any links to relevant issues. If this is closing an existing issue use one of the issue linking keywords to link the issue to this PR and have it automatically close when completed.
In addition, go through the checklist below and check each item as you validate it is either handled or not applicable to this change.
Code Changes