Fixing a bug with regex_Like function as Boolean exp#166
Merged
Conversation
llali
requested review from
chlafreniere,
dzsquared,
kburtram,
ssreerama and
zijchen
as code owners
|
Note that fixing this bug will hopefully fix #28 at the same time, as I believe it is caused by the same root issue. |
Member
Author
I don't think so but I'll double check |
zijchen
approved these changes
Sep 19, 2025
| ++insideIIf; | ||
| } | ||
| // if identifier is REGEXP_LIKE | ||
| else if(NextTokenMatches(CodeGenerationSupporter.RegexpLike)) |
Contributor
There was a problem hiding this comment.
Would it be more appropriate to add it to TSql170ParserBaseInternal or whichever version introduces this syntax?
Member
Author
There was a problem hiding this comment.
probably yes but it's fine since we added other syntaxes here as well. I can rename the function later
ssreerama
approved these changes
Sep 19, 2025
|
@llali could you release this fix so that we can test it out? |
Member
Author
|
@clement911 this should be in 170.128.0 |
|
Ah yes thank you @llali , confirming it works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #160
In addition, go through the checklist below and check each item as you validate it is either handled or not applicable to this change.
Code Changes