adds formatter option for preserving comments#172
Closed
Conversation
correcting logic in tests single line comments handled correctly next set of tests passing comment inclusion defaults to false cleanup debugging files cleanup debugging output extend tests improve multi-comment handling
…kwier-preservecomments
…kwier-preservecomments
dzsquared
requested review from
chlafreniere,
kburtram,
llali and
ssreerama
as code owners
|
Well, this is exciting :) |
|
Merge, merge, merge :) |
Contributor
Author
almost! there's a few more scenarios I'm getting sorted out. |
|
|
|
Looks like @dzsquared is having a long christmas break. |
Contributor
Author
|
I'm sure this is painful for some of you who really want to see this merged, but I didn't like how this attempt came together and re-did it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #20
enables the code formatter to preserve T-SQL comments, including
Code Changes