fix: fix langchain error handling to avoid crash on openai>1.0.0#2307
Merged
mhamilton723 merged 3 commits intomicrosoft:masterfrom Nov 12, 2024
Merged
fix: fix langchain error handling to avoid crash on openai>1.0.0#2307mhamilton723 merged 3 commits intomicrosoft:masterfrom
mhamilton723 merged 3 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lhrotk
changed the title
lhrotk
changed the title
lhrotk
changed the title
mhamilton723
approved these changes
Nov 5, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2307 +/- ##
=======================================
Coverage 84.48% 84.48%
=======================================
Files 326 326
Lines 16769 16769
Branches 1480 1480
=======================================
Hits 14168 14168
Misses 2601 2601 ☔ View full report in Codecov by Sentry. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
N/A
What changes are proposed in this pull request?
The code referencing openai<1.0 classes can't run when you have openai>1.0.
How is this patch tested?
Manual tested
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?