Skip to content

Conversation

@Andarist
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@Andarist Andarist force-pushed the permission-name-map branch from ee941b3 to ced7d7f Compare June 15, 2023 08:43
@saschanaz
Copy link
Contributor

Interesting approach. Do you have any specific permission in mind you want to enable through this, BTW?

@Andarist
Copy link
Contributor Author

Interesting approach.

I've seen other *Map types here and I thought that this was a somewhat established pattern here. But perhaps those other types had a different purpose after all 😅

Do you have any specific permission in mind you want to enable through this, BTW?

A friend of mine was trying to augment the related functions with 'clipboard-write' | 'clipboard-read'.

@saschanaz
Copy link
Contributor

I've seen other *Map types here and I thought that this was a somewhat established pattern here. But perhaps those other types had a different purpose after all 😅

The key difference is that this one is not really a map but a list, while others are actual maps. Maybe rename?

A friend of mine was trying to augment the related functions with 'clipboard-write' | 'clipboard-read'.

In most cases you don't need those permissions, since user interaction e.g. mouse click and key push will automatically grant those permission for a short time (which is called transient user activation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants