Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make most textContent not nullable #1942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make most textContent not nullable #1942

wants to merge 2 commits into from

Conversation

alex-kinokon
Copy link

@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@alex-kinokon
Copy link
Author

@microsoft-github-policy-service agree

saschanaz
saschanaz reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One thing, given the spec also mentions DocumentFragment, can you also cover that here?

inputfiles/addedTypes.jsonc
@@ -11,6 +11,19 @@
]
}
},
"Comment": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no mixin named Comment and thus this doesn't do anything. Comment inherits from CharacterData so this is not needed either.

@saschanaz
Copy link
Contributor

(Making it textContent: null; for other Node-inheriting interfaces would be a bonus)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element.textContent should not be nullable
2 participants
@alex-kinokon @saschanaz