-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch web api descriptions from MDN #625
Merged
+1,043
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import * as fs from "fs"; | ||
import fetch from "node-fetch"; | ||
import { JSDOM } from "jsdom"; | ||
|
||
interface Page { | ||
summary: string; | ||
} | ||
|
||
const knownBadDescriptions = [ | ||
"CustomEvent", // too vague; references truncated data | ||
"IDBTransaction", // just a comment about Firefox 40 | ||
"RTCDtmfSender", // is just 'tbd' | ||
"SVGMatrix", // too vague; references truncated data | ||
]; | ||
|
||
fetchInterfaceDescriptions(); | ||
|
||
async function fetchInterfaceDescriptions() { | ||
const webIdl = require("../inputfiles/browser.webidl.preprocessed.json"); | ||
const interfaceNames = Object.keys(webIdl.interfaces.interface).sort(); | ||
const descriptions: Record<string, string> = {}; | ||
|
||
await interfaceNames.reduce(async (previousRequest, name) => { | ||
// Issuing too many requests in parallel causes 504 gateway errors, so chain | ||
await previousRequest; | ||
|
||
const response = await fetch(`https://developer.mozilla.org/en-US/docs/Web/API/${name}$json`); | ||
if (response.ok) { | ||
const page = await response.json(); | ||
addDescription(name, page); | ||
} else if (response.status !== 404) { | ||
throw new Error(`Failed to fetch ${name}: ${response.statusText}`); | ||
} | ||
}, Promise.resolve()); | ||
|
||
function addDescription(name: string, page: Page) { | ||
if (page.summary && !knownBadDescriptions.includes(name)) { | ||
const fragment = JSDOM.fragment(page.summary); | ||
descriptions[name] = fragment.textContent!; | ||
} | ||
} | ||
|
||
fs.writeFileSync("inputfiles/mdn/apiDescriptions.json", JSON.stringify(descriptions, null, 2)); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just make this whole thing synchronous then? (Probably because node-fetch is 500x more popular than the nearest synchronous package)