prevent early binding of importClause in jsdoc imports

microsoft · Jan 19, 2025 · 7c18a9c · 7c18a9c
1 parent 49cdbda
commit 7c18a9c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts
@@ -1110,10 +1110,12 @@ function createBinder(): (file: SourceFile, options: CompilerOptions) => void {
                 node.flowNode = undefined;
             }
             if (isJSDocImportTag(node)) {
-                return;
+                bindJSDocImportTag(node);
+            }
+            else {
+                bindEachChild(node);
+                bindJSDoc(node);
             }
-            bindEachChild(node);
-            bindJSDoc(node);
             inAssignmentPattern = saveInAssignmentPattern;
             return;
         }

diff --git a/tests/baselines/reference/importTag24.errors.txt b/tests/baselines/reference/importTag24.errors.txt
@@ -8,7 +8,7 @@ a.js(19,17): error TS2322: Type 'number' is not assignable to type 'string'.
     export type Foo = string;
 
 ==== a.js (4 errors) ====
-    /** @import { Foo } from './types.d.ts') */
+    /** @import { Foo } from './types.d.ts' */
 
     function f1() { return undefined; }
              ~~

diff --git a/tests/baselines/reference/importTag24.symbols b/tests/baselines/reference/importTag24.symbols
@@ -5,7 +5,7 @@ export type Foo = string;
 >Foo : Symbol(Foo, Decl(types.d.ts, 0, 0))
 
 === a.js ===
-/** @import { Foo } from './types.d.ts') */
+/** @import { Foo } from './types.d.ts' */
 
 function f1() { return undefined; }
 >f1 : Symbol(f1, Decl(a.js, 0, 0))

diff --git a/tests/baselines/reference/importTag24.types b/tests/baselines/reference/importTag24.types
@@ -10,7 +10,7 @@ export type Foo = string;
 >    : ^^^^^^
 
 === a.js ===
-/** @import { Foo } from './types.d.ts') */
+/** @import { Foo } from './types.d.ts' */
 
 function f1() { return undefined; }
 >f1 : () => any

diff --git a/tests/cases/conformance/jsdoc/importTag24.ts b/tests/cases/conformance/jsdoc/importTag24.ts
@@ -12,7 +12,7 @@
 export type Foo = string;
 
 // @filename: a.js
-/** @import { Foo } from './types.d.ts') */
+/** @import { Foo } from './types.d.ts' */
 
 function f1() { return undefined; }