Fix forEachChild to include withClause for ModuleDeclaration

The test harness validates that all child nodes are visited by forEachChild
in the correct order (by position in the source code).

We added withClause to ModuleDeclaration but:
1. Forgot to update the forEachChild visitor in parser.ts to include it
2. Had it in the wrong order - withClause comes BEFORE body in the syntax

The syntax is: declare module "name" with { ... } { ... }
So the order is: modifiers → name → withClause → body

This commit adds withClause to forEachChild in the correct position.

Author: jonathantneal

src/compiler/parser.ts

@@ -923,6 +923,7 @@ const forEachChildTable: ForEachChildTable = {
     [SyntaxKind.ModuleDeclaration]: function forEachChildInModuleDeclaration<T>(node: ModuleDeclaration, cbNode: (node: Node) => T | undefined, cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {
         return visitNodes(cbNode, cbNodes, node.modifiers) ||
             visitNode(cbNode, node.name) ||
+            visitNode(cbNode, node.withClause) ||
             visitNode(cbNode, node.body);
     },
     [SyntaxKind.ImportEqualsDeclaration]: function forEachChildInImportEqualsDeclaration<T>(node: ImportEqualsDeclaration, cbNode: (node: Node) => T | undefined, cbNodes?: (nodes: NodeArray<Node>) => T | undefined): T | undefined {

tests/baselines/reference/ambientModuleWithImportAttributes.types

@@ -5,6 +5,8 @@
 declare module "*.css" with { type: "css" } {
 >"*.css" : typeof import("*.css")
 >        : ^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     const stylesheet: CSSStyleSheet;
 >stylesheet : CSSStyleSheet
@@ -18,6 +20,8 @@ declare module "*.css" with { type: "css" } {
 declare module "*.json" with { type: "json" } {
 >"*.json" : typeof import("*.json")
 >         : ^^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     const data: any;
 >data : any
@@ -32,6 +36,8 @@ declare module "*.json" with { type: "json" } {
 declare module "my-module" with { type: "custom" } {
 >"my-module" : typeof import("my-module")
 >            : ^^^^^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     export function foo(): void;
 >foo : () => void
@@ -46,6 +52,10 @@ declare module "my-module" with { type: "custom" } {
 declare module "multi-attr" with { type: "json", integrity: "sha384-..." } {
 >"multi-attr" : typeof import("multi-attr")
 >             : ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
+>integrity : any
+>          : ^^^
 
     export const value: number;
 >value : number

tests/baselines/reference/ambientModuleWithImportAttributesDiagnostics.types

@@ -5,6 +5,8 @@
 declare module "*.css" with { type: "css" } {
 >"*.css" : typeof import("*.css")
 >        : ^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     const stylesheet: CSSStyleSheet;
 >stylesheet : CSSStyleSheet
@@ -18,6 +20,8 @@ declare module "*.css" with { type: "css" } {
 declare module "*.json" with { type: "json" } {
 >"*.json" : typeof import("*.json")
 >         : ^^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     const data: any;
 >data : any

tests/baselines/reference/ambientModuleWithImportAttributesSemantics.types

@@ -5,6 +5,8 @@
 declare module "*.css" with { type: "css" } {
 >"*.css" : typeof import("*.css")
 >        : ^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     const stylesheet: CSSStyleSheet;
 >stylesheet : CSSStyleSheet
@@ -19,6 +21,8 @@ declare module "*.css" with { type: "css" } {
 declare module "*.json" with { type: "json" } {
 >"*.json" : typeof import("*.json")
 >         : ^^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
 
     const data: any;
 >data : any
@@ -47,6 +51,10 @@ declare module "*.txt" {
 declare module "*.wasm" with { type: "module", version: "1" } {
 >"*.wasm" : typeof import("*.wasm")
 >         : ^^^^^^^^^^^^^^^^^^^^^^^
+>type : any
+>     : ^^^
+>version : any
+>        : ^^^
 
     const module: WebAssembly.Module;
 >module : WebAssembly.Module