Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new option "libReplacement" #60829

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add new option "libReplacement" #60829

wants to merge 4 commits into from
+1,230 −71

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Dec 19, 2024 •
edited
Loading

Lib replacement (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#supporting-lib-from-node_modules) allows specially-named packages in node_modules to replace TypeScript's bundled lib.d.ts files. This feature is always on, so we always perform resolution to look for it in case it exists. This can have a negative perf impact; it's extra watchers, extra CPU time, extra IO, etc.

This PR adds a new compiler option libReplacement to control the feature; by default, it's enabled. In TS 6.0, it will be disabled by default.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 19, 2024
@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 19, 2024 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60829/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,363 62,363 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 193,620k (± 0.76%) 193,000k (± 0.10%) ~ 192,861k 193,244k p=0.230 n=6
Parse Time 1.32s (± 0.42%) 1.30s (± 0.93%) ~ 1.29s 1.32s p=0.090 n=6
Bind Time 0.72s 0.71s -0.01s (- 1.39%) ~ ~ p=0.001 n=6
Check Time 9.76s (± 0.34%) 9.79s (± 0.20%) +0.04s (+ 0.36%) 9.76s 9.81s p=0.043 n=6
Emit Time 2.73s (± 0.73%) 2.73s (± 0.28%) ~ 2.72s 2.74s p=0.869 n=6
Total Time 14.52s (± 0.36%) 14.54s (± 0.17%) ~ 14.50s 14.56s p=0.628 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 947,936 947,936 ~ ~ ~ p=1.000 n=6
Types 410,955 410,955 ~ ~ ~ p=1.000 n=6
Memory used 1,225,783k (± 0.00%) 1,224,782k (± 0.00%) -1,001k (- 0.08%) 1,224,709k 1,224,835k p=0.005 n=6
Parse Time 6.65s (± 0.62%) 6.55s (± 0.56%) -0.10s (- 1.48%) 6.51s 6.60s p=0.006 n=6
Bind Time 1.89s (± 0.29%) 1.88s (± 1.28%) ~ 1.86s 1.93s p=0.228 n=6
Check Time 31.99s (± 0.37%) 31.96s (± 0.41%) ~ 31.80s 32.13s p=0.810 n=6
Emit Time 15.19s (± 0.25%) 15.12s (± 0.65%) ~ 14.93s 15.21s p=0.126 n=6
Total Time 55.71s (± 0.17%) 55.52s (± 0.35%) -0.19s (- 0.34%) 55.21s 55.75s p=0.045 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,449,172 2,449,172 ~ ~ ~ p=1.000 n=6
Types 896,410 896,410 ~ ~ ~ p=1.000 n=6
Memory used 2,320,766k (± 0.00%) 2,319,699k (± 0.00%) -1,067k (- 0.05%) 2,319,654k 2,319,791k p=0.005 n=6
Parse Time 9.40s (± 0.20%) 9.39s (± 0.13%) ~ 9.37s 9.40s p=0.406 n=6
Bind Time 2.24s (± 0.18%) 2.24s (± 0.37%) ~ 2.23s 2.25s p=0.285 n=6
Check Time 73.51s (± 0.49%) 73.73s (± 0.64%) ~ 72.92s 74.18s p=0.298 n=6
Emit Time 0.27s (± 1.89%) 0.28s +0.01s (+ 2.44%) ~ ~ p=0.025 n=6
Total Time 85.42s (± 0.43%) 85.63s (± 0.54%) ~ 84.83s 86.08s p=0.298 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,880 1,226,965 +85 (+ 0.01%) ~ ~ p=0.001 n=6
Types 266,745 266,768 +23 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 2,357,644k (± 0.02%) 2,457,134k (± 7.64%) ~ 2,335,833k 2,699,767k p=0.378 n=6
Parse Time 5.22s (± 1.19%) 5.21s (± 1.33%) ~ 5.16s 5.34s p=0.689 n=6
Bind Time 1.75s (± 0.86%) 1.76s (± 1.04%) ~ 1.73s 1.78s p=0.510 n=6
Check Time 35.23s (± 0.15%) 35.03s (± 0.65%) ~ 34.76s 35.39s p=0.066 n=6
Emit Time 2.96s (± 1.03%) 3.01s (± 0.98%) +0.05s (+ 1.63%) 2.96s 3.04s p=0.043 n=6
Total Time 45.18s (± 0.25%) 45.01s (± 0.42%) ~ 44.81s 45.37s p=0.066 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,226,880 1,226,965 +85 (+ 0.01%) ~ ~ p=0.001 n=6
Types 266,745 266,768 +23 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 2,911,942k (±12.86%) 3,131,439k (± 0.02%) ~ 3,130,166k 3,132,105k p=0.378 n=6
Parse Time 6.96s (± 1.31%) 6.91s (± 0.77%) ~ 6.84s 6.99s p=0.336 n=6
Bind Time 2.17s (± 1.65%) 2.18s (± 0.69%) ~ 2.16s 2.19s p=0.747 n=6
Check Time 42.81s (± 0.71%) 42.86s (± 0.50%) ~ 42.54s 43.08s p=0.936 n=6
Emit Time 3.52s (± 2.51%) 3.53s (± 1.36%) ~ 3.46s 3.59s p=1.000 n=6
Total Time 55.46s (± 0.54%) 55.50s (± 0.43%) ~ 55.14s 55.84s p=1.000 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,439 262,468 +29 (+ 0.01%) ~ ~ p=0.001 n=6
Types 106,628 106,646 +18 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 440,204k (± 0.01%) 439,119k (± 0.01%) -1,085k (- 0.25%) 439,031k 439,167k p=0.005 n=6
Parse Time 3.53s (± 1.33%) 3.44s (± 0.65%) -0.09s (- 2.41%) 3.41s 3.48s p=0.005 n=6
Bind Time 1.31s (± 1.63%) 1.29s (± 1.30%) ~ 1.27s 1.32s p=0.106 n=6
Check Time 18.94s (± 0.25%) 18.94s (± 0.30%) ~ 18.87s 19.02s p=0.872 n=6
Emit Time 1.53s (± 0.76%) 1.54s (± 1.27%) ~ 1.51s 1.56s p=0.222 n=6
Total Time 25.31s (± 0.30%) 25.22s (± 0.14%) ~ 25.16s 25.26s p=0.065 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,062 226,062 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,627k (± 0.01%) 370,508k (± 0.03%) -1,119k (- 0.30%) 370,451k 370,717k p=0.005 n=6
Parse Time 2.90s (± 1.17%) 2.87s (± 1.64%) ~ 2.78s 2.92s p=0.227 n=6
Bind Time 1.59s (± 0.97%) 1.58s (± 1.35%) ~ 1.56s 1.61s p=0.465 n=6
Check Time 16.44s (± 0.20%) 16.48s (± 0.34%) ~ 16.40s 16.55s p=0.261 n=6
Emit Time 0.00s (±244.70%) 0.00s (±244.70%) ~ 0.00s 0.01s p=1.000 n=6
Total Time 20.93s (± 0.21%) 20.93s (± 0.41%) ~ 20.79s 21.00s p=0.687 n=6
vscode - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 3,224,468 3,224,468 ~ ~ ~ p=1.000 n=6
Types 1,109,187 1,109,187 ~ ~ ~ p=1.000 n=6
Memory used 3,290,008k (± 0.01%) 3,288,983k (± 0.01%) -1,026k (- 0.03%) 3,288,586k 3,289,252k p=0.005 n=6
Parse Time 14.14s (± 0.38%) 14.19s (± 0.62%) ~ 14.09s 14.34s p=0.227 n=6
Bind Time 4.56s (± 0.42%) 4.52s (± 0.23%) -0.04s (- 0.80%) 4.51s 4.54s p=0.007 n=6
Check Time 88.49s (± 3.32%) 89.01s (± 1.88%) ~ 86.76s 90.41s p=0.748 n=6
Emit Time 27.80s (± 8.64%) 28.00s (± 2.67%) ~ 27.40s 29.00s p=0.298 n=6
Total Time 134.98s (± 0.73%) 135.73s (± 0.71%) ~ 134.37s 136.56s p=0.230 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 291,562 291,562 ~ ~ ~ p=1.000 n=6
Types 118,971 118,971 ~ ~ ~ p=1.000 n=6
Memory used 445,402k (± 0.01%) 444,426k (± 0.03%) -977k (- 0.22%) 444,239k 444,607k p=0.005 n=6
Parse Time 4.08s (± 0.65%) 4.04s (± 1.05%) ~ 3.99s 4.09s p=0.106 n=6
Bind Time 1.79s (± 0.55%) 1.78s (± 1.26%) ~ 1.76s 1.82s p=0.391 n=6
Check Time 18.81s (± 0.33%) 18.84s (± 0.63%) ~ 18.64s 18.96s p=0.225 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.70s (± 0.35%) 24.66s (± 0.64%) ~ 24.41s 24.84s p=1.000 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 552,233 552,233 ~ ~ ~ p=1.000 n=6
Types 184,971 184,971 ~ ~ ~ p=1.000 n=6
Memory used 492,410k (± 0.01%) 491,348k (± 0.03%) -1,062k (- 0.22%) 491,069k 491,470k p=0.005 n=6
Parse Time 4.25s (± 0.24%) 4.20s (± 0.28%) -0.05s (- 1.14%) 4.18s 4.21s p=0.005 n=6
Bind Time 1.46s (± 0.35%) 1.47s (± 1.43%) ~ 1.44s 1.49s p=0.459 n=6
Check Time 24.11s (± 0.40%) 24.16s (± 0.95%) ~ 24.00s 24.61s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.81s (± 0.35%) 29.83s (± 0.76%) ~ 29.67s 30.28s p=0.471 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60829/merge:

Everything looks good!

@jakebailey
Copy link
Member Author

I guess nobody in our extended test suite uses this feature, or at least, their use of it does not actually "help" anything. Which all is a good thing.

@jakebailey jakebailey marked this pull request as ready for review January 8, 2025 22:19
@jakebailey
Copy link
Member Author

jakebailey commented Jan 8, 2025 •
edited
Loading

I am tentatively marking this as ready for review; it doesn't really seem like anyone is using lib replacement at all in our extended suite, and this is IMO a good optimization which avoids setting up a load of failed resolution watchers. But, maybe this just needs to wait for 6.0.

The only thing this PR is probably missing are unit tests / some verification of the options I set on it, which I believe are probably wrong (should be more than affectsSemanticDiagnostics? I can never get these right.).

@jakebailey
Copy link
Member Author

@typescript-bot perf test tsserver-only

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 10, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test tsserver-only ✅ Started 👀 Results

@jakebailey
Copy link
Member Author

Consensus in the design meeting was to default this to "true" (do lib replacement) until 6.0 where we default it to "false" (don't do lib replacement).

Also, name can be bikeshedded.

@jakebailey jakebailey marked this pull request as draft January 10, 2025 19:24
@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,325ms (± 0.27%) 2,293ms (± 0.69%) -32ms (- 1.36%) 2,273ms 2,314ms p=0.005 n=6
Req 2 - geterr 5,313ms (± 0.23%) 5,314ms (± 0.35%) ~ 5,288ms 5,336ms p=0.936 n=6
Req 3 - references 264ms (± 1.64%) 267ms (± 1.12%) ~ 263ms 269ms p=0.209 n=6
Req 4 - navto 225ms (± 0.59%) 217ms (± 0.39%) 🟩-9ms (- 3.85%) 216ms 218ms p=0.004 n=6
Req 5 - completionInfo count 1,357 1,357 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 77ms (± 2.81%) 75ms (± 0.54%) -2ms (- 2.39%) 74ms 75ms p=0.009 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,440ms (± 0.94%) 2,400ms (± 0.57%) -40ms (- 1.64%) 2,386ms 2,422ms p=0.008 n=6
Req 2 - geterr 4,007ms (± 0.42%) 3,995ms (± 0.58%) ~ 3,973ms 4,029ms p=0.298 n=6
Req 3 - references 279ms (± 1.12%) 279ms (± 1.69%) ~ 273ms 285ms p=0.742 n=6
Req 4 - navto 227ms 223ms (± 0.18%) -4ms (- 1.84%) 222ms 223ms p=0.002 n=6
Req 5 - completionInfo count 1,519 1,519 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 83ms (± 5.11%) 83ms (± 6.78%) ~ 75ms 87ms p=1.000 n=6
xstate-main-1-tsserver - node (v18.15.0, x64)
Req 1 - updateOpen 5,280ms (± 0.63%) 5,257ms (± 0.35%) ~ 5,224ms 5,275ms p=0.378 n=6
Req 2 - geterr 1,149ms (± 0.32%) 1,153ms (± 1.07%) ~ 1,142ms 1,176ms p=0.872 n=6
Req 3 - references 77ms (± 4.19%) 83ms (± 5.61%) 🔻+6ms (+ 7.84%) 77ms 87ms p=0.018 n=6
Req 4 - navto 451ms (± 0.75%) 449ms (± 0.53%) ~ 446ms 451ms p=0.568 n=6
Req 5 - completionInfo count 3,450 3,450 ~ ~ ~ p=1.000 n=6
Req 5 - completionInfo 828ms (± 1.36%) 832ms (± 1.85%) ~ 806ms 850ms p=0.575 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstate-main-1-tsserver - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey jakebailey changed the title Add new option "libReplacement", disable by default Add new option "libReplacement" Jan 11, 2025
@jakebailey jakebailey marked this pull request as ready for review January 11, 2025 01:00
jakebailey
jakebailey commented Jan 11, 2025
View reviewed changes
tests/baselines/reference/libReplacement(libreplacement=false).trace.json
@@ -0,0 +1 @@
[]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare to tests/baselines/reference/libReplacement(libreplacement=true).trace.json below, which has 1003 lines of traces for an empty file with lib=esnext.

@uhyo uhyo mentioned this pull request Jan 13, 2025
Open
@jakebailey
Copy link
Member Author

@typescript-bot test it

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 13, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60829/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 193,176k (± 0.08%) 194,923k (± 1.02%) ~ 193,032k 196,774k p=0.230 n=6
Parse Time 1.30s (± 0.79%) 1.30s (± 0.75%) ~ 1.29s 1.31s p=0.784 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.78s (± 0.31%) 9.75s (± 0.21%) ~ 9.71s 9.77s p=0.165 n=6
Emit Time 2.73s (± 0.43%) 2.73s (± 1.10%) ~ 2.71s 2.78s p=0.741 n=6
Total Time 14.54s (± 0.18%) 14.51s (± 0.34%) ~ 14.46s 14.57s p=0.518 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 947,969 947,969 ~ ~ ~ p=1.000 n=6
Types 410,955 410,955 ~ ~ ~ p=1.000 n=6
Memory used 1,225,658k (± 0.00%) 1,225,670k (± 0.00%) ~ 1,225,593k 1,225,743k p=0.470 n=6
Parse Time 6.65s (± 0.86%) 6.64s (± 0.65%) ~ 6.58s 6.68s p=0.746 n=6
Bind Time 1.90s (± 0.27%) 1.89s (± 0.64%) ~ 1.87s 1.90s p=0.070 n=6
Check Time 32.07s (± 0.38%) 32.01s (± 0.48%) ~ 31.83s 32.29s p=0.229 n=6
Emit Time 15.18s (± 0.39%) 15.18s (± 0.33%) ~ 15.11s 15.24s p=0.936 n=6
Total Time 55.81s (± 0.24%) 55.71s (± 0.37%) ~ 55.49s 56.10s p=0.065 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,445,991 2,445,991 ~ ~ ~ p=1.000 n=6
Types 896,571 896,571 ~ ~ ~ p=1.000 n=6
Memory used 2,309,665k (± 0.00%) 2,309,664k (± 0.00%) ~ 2,309,597k 2,309,697k p=0.689 n=6
Parse Time 8.92s (± 0.50%) 8.92s (± 0.56%) ~ 8.88s 8.99s p=0.871 n=6
Bind Time 2.12s (± 0.91%) 2.13s (± 0.49%) ~ 2.11s 2.14s p=0.869 n=6
Check Time 73.39s (± 0.66%) 73.25s (± 0.58%) ~ 72.78s 74.00s p=0.471 n=6
Emit Time 0.28s (± 2.67%) 0.29s (± 3.68%) ~ 0.27s 0.30s p=0.611 n=6
Total Time 84.72s (± 0.58%) 84.58s (± 0.54%) ~ 84.09s 85.39s p=0.470 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,377 1,228,460 +83 (+ 0.01%) ~ ~ p=0.001 n=6
Types 266,839 266,863 +24 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 2,359,670k (± 0.01%) 2,360,211k (± 0.01%) +540k (+ 0.02%) 2,359,700k 2,360,638k p=0.020 n=6
Parse Time 5.22s (± 0.48%) 5.18s (± 0.52%) -0.04s (- 0.70%) 5.15s 5.23s p=0.037 n=6
Bind Time 1.79s (± 0.58%) 1.78s (± 1.00%) ~ 1.76s 1.81s p=0.255 n=6
Check Time 35.22s (± 0.21%) 35.26s (± 0.31%) ~ 35.14s 35.43s p=0.521 n=6
Emit Time 3.00s (± 1.09%) 3.01s (± 0.94%) ~ 2.98s 3.05s p=0.748 n=6
Total Time 45.23s (± 0.13%) 45.24s (± 0.26%) ~ 45.08s 45.37s p=0.936 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,377 1,228,460 +83 (+ 0.01%) ~ ~ p=0.001 n=6
Types 266,839 266,863 +24 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 3,036,025k (± 9.75%) 2,914,614k (±12.86%) ~ 2,429,441k 3,158,263k p=0.378 n=6
Parse Time 6.98s (± 1.80%) 6.93s (± 1.50%) ~ 6.79s 7.02s p=0.261 n=6
Bind Time 2.16s (± 2.14%) 2.16s (± 1.16%) ~ 2.13s 2.19s p=1.000 n=6
Check Time 42.91s (± 0.66%) 42.88s (± 0.44%) ~ 42.63s 43.18s p=0.689 n=6
Emit Time 3.49s (± 2.52%) 3.51s (± 2.26%) ~ 3.38s 3.63s p=0.629 n=6
Total Time 55.55s (± 0.48%) 55.48s (± 0.42%) ~ 55.10s 55.82s p=0.471 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,624 262,651 +27 (+ 0.01%) ~ ~ p=0.001 n=6
Types 106,695 106,714 +19 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 440,803k (± 0.01%) 440,854k (± 0.02%) ~ 440,703k 440,925k p=0.128 n=6
Parse Time 3.55s (± 1.13%) 3.54s (± 0.75%) ~ 3.51s 3.59s p=0.629 n=6
Bind Time 1.31s (± 1.01%) 1.32s (± 1.00%) ~ 1.31s 1.34s p=0.366 n=6
Check Time 19.03s (± 0.40%) 19.00s (± 0.67%) ~ 18.84s 19.15s p=0.748 n=6
Emit Time 1.54s (± 0.92%) 1.53s (± 0.55%) ~ 1.51s 1.53s p=0.067 n=6
Total Time 25.44s (± 0.43%) 25.39s (± 0.46%) ~ 25.25s 25.53s p=0.521 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,095 226,095 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,770k (± 0.05%) 371,735k (± 0.05%) ~ 371,595k 372,090k p=0.575 n=6
Parse Time 2.92s (± 1.26%) 2.90s (± 0.70%) ~ 2.87s 2.93s p=0.466 n=6
Bind Time 1.60s (± 1.55%) 1.60s (± 1.52%) ~ 1.56s 1.62s p=0.935 n=6
Check Time 16.50s (± 0.23%) 16.52s (± 0.33%) ~ 16.46s 16.61s p=0.688 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.02s (± 0.24%) 21.01s (± 0.41%) ~ 20.90s 21.14s p=1.000 n=6
vscode - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 3,238,957 3,238,957 ~ ~ ~ p=1.000 n=6
Types 1,115,491 1,115,491 ~ ~ ~ p=1.000 n=6
Memory used 3,306,788k (± 0.01%) 3,306,726k (± 0.01%) ~ 3,306,272k 3,307,061k p=0.689 n=6
Parse Time 14.20s (± 0.59%) 14.15s (± 0.43%) ~ 14.10s 14.25s p=0.226 n=6
Bind Time 4.60s (± 2.16%) 4.59s (± 2.22%) ~ 4.54s 4.80s p=0.681 n=6
Check Time 87.96s (± 1.14%) 89.04s (± 3.08%) ~ 87.25s 94.15s p=0.873 n=6
Emit Time 27.61s (± 1.01%) 27.99s (± 2.78%) ~ 27.28s 29.10s p=0.471 n=6
Total Time 134.37s (± 0.71%) 135.77s (± 2.39%) ~ 133.31s 141.96s p=0.936 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 291,595 291,595 ~ ~ ~ p=1.000 n=6
Types 118,971 118,971 ~ ~ ~ p=1.000 n=6
Memory used 445,402k (± 0.02%) 445,310k (± 0.04%) ~ 444,956k 445,486k p=0.575 n=6
Parse Time 5.06s (± 1.31%) 5.08s (± 0.92%) ~ 5.03s 5.15s p=0.421 n=6
Bind Time 2.20s (± 1.32%) 2.20s (± 1.30%) ~ 2.17s 2.25s p=1.000 n=6
Check Time 23.34s (± 0.37%) 23.52s (± 2.00%) ~ 23.22s 24.47s p=0.689 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.60s (± 0.45%) 30.81s (± 1.50%) ~ 30.45s 31.72s p=0.688 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,050 555,050 ~ ~ ~ p=1.000 n=6
Types 186,115 186,115 ~ ~ ~ p=1.000 n=6
Memory used 494,008k (± 0.01%) 493,958k (± 0.02%) ~ 493,748k 494,079k p=0.471 n=6
Parse Time 3.40s (± 0.48%) 3.40s (± 0.61%) ~ 3.39s 3.44s p=1.000 n=6
Bind Time 1.18s (± 0.87%) 1.19s (± 1.24%) ~ 1.17s 1.20s p=0.562 n=6
Check Time 19.58s (± 0.41%) 19.66s (± 1.22%) ~ 19.53s 20.15s p=0.936 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.17s (± 0.35%) 24.26s (± 0.93%) ~ 24.11s 24.71s p=0.810 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60829/merge:

Everything looks good!

@DanielRosenwasser DanielRosenwasser mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

@weswigham weswigham Awaiting requested review from weswigham

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakebailey @typescript-bot @andrewbranch @RyanCavanaugh