DOM update 2025/01/29 #61073

sandersn · 2025-01-29T16:43:25Z

I want this into nightly soon to make sure that
microsoft/TypeScript-DOM-lib-generator#1598 is good to ship for the RC. It changes return types of 5 functions from Promise<undefined> to Promise<void>. This should improve compatibility since it's the way the rest of the DOM is, but it's also been long enough that I want to check to make sure.

This is going into nightly to make sure that microsoft/TypeScript-DOM-lib-generator#1598 is goodto ship for the RC.

sandersn · 2025-01-29T16:46:43Z

@typescript-bot test this

typescript-bot · 2025-01-29T16:46:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-29T17:09:21Z

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: rusha
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rusha/index.d.ts
  19:11  error  TypeScript@local compile error: 
Interface 'RushaWorker' incorrectly extends interface 'Worker'.
  Types of property 'onmessage' are incompatible.
    Type '((this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void) | null' is not assignable to type '((this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any) | null'.
      Type '(this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void' is not assignable to type '(this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any'.
        The 'this' types of each signature are incompatible.
          Type 'MessageEventTarget<Worker>' is missing the following properties from type 'RushaWorker': postMessage, terminate, dispatchEvent, onerror  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<void>', but here has type 'Promise<undefined>'               @definitelytyped/expect
  7:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<void>', but here has type 'Promise<undefined>'            @definitelytyped/expect
  8:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<void>', but here has type 'Promise<undefined>'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Errors that changed between main and the branch:

Package: dom-webcodecs
Main error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Branch error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  505:6  error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

jakebailey · 2025-01-29T17:09:31Z

@typescript-bot user test this

typescript-bot · 2025-01-29T17:09:38Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`user test this`	✅ Started	✅ Results

typescript-bot · 2025-01-29T17:32:26Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,127k (± 0.02%)}	_{194,974k (± 1.04%)}	_~	_193,097k	_196,977k	_{p=0.173 n=6}
_{Parse Time}	_1.31s	_{1.31s (± 0.39%)}	_~	_1.31s	_1.32s	_{p=0.174 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.13%)}	_{9.77s (± 0.16%)}	_~	_9.75s	_9.79s	_{p=0.328 n=6}
_{Emit Time}	_{2.73s (± 0.78%)}	_{2.74s (± 0.95%)}	_~	_2.70s	_2.78s	_{p=0.868 n=6}
_{Total Time}	_{14.53s (± 0.24%)}	_{14.54s (± 0.25%)}	_~	_14.50s	_14.60s	_{p=0.871 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,493	_948,488	_{-5 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_411,005	_411,006	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,427k (± 0.00%)}	_{1,225,423k (± 0.00%)}	_~	_1,225,365k	_1,225,467k	_{p=1.000 n=6}
_{Parse Time}	_{6.65s (± 0.79%)}	_{6.67s (± 0.79%)}	_~	_6.57s	_6.71s	_{p=0.373 n=6}
_{Bind Time}	_{1.89s (± 0.54%)}	_{1.89s (± 0.78%)}	_~	_1.87s	_1.91s	_{p=0.931 n=6}
_{Check Time}	_{31.97s (± 0.24%)}	_{31.97s (± 0.33%)}	_~	_31.80s	_32.11s	_{p=0.936 n=6}
_{Emit Time}	_{15.21s (± 0.76%)}	_{15.22s (± 0.27%)}	_~	_15.17s	_15.29s	_{p=1.000 n=6}
_{Total Time}	_{55.73s (± 0.18%)}	_{55.75s (± 0.18%)}	_~	_55.63s	_55.88s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,050	_2,447,052	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_898,533	_898,533	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,737k (± 0.00%)}	_{2,307,821k (± 0.00%)}	_{+84k (+ 0.00%)}	_2,307,785k	_2,307,862k	_{p=0.005 n=6}
_{Parse Time}	_{8.91s (± 0.20%)}	_{8.91s (± 0.19%)}	_~	_8.89s	_8.93s	_{p=0.737 n=6}
_{Bind Time}	_{2.17s (± 0.35%)}	_{2.17s (± 0.38%)}	_~	_2.16s	_2.18s	_{p=0.432 n=6}
_{Check Time}	_{74.20s (± 0.33%)}	_{74.16s (± 0.36%)}	_~	_73.86s	_74.50s	_{p=0.748 n=6}
_{Emit Time}	_{0.28s (± 1.45%)}	_{0.28s (± 1.47%)}	_~	_0.27s	_0.28s	_{p=0.218 n=6}
_{Total Time}	_{85.57s (± 0.28%)}	_{85.52s (± 0.30%)}	_~	_85.25s	_85.84s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,362,063k (± 0.03%)}	_{2,362,153k (± 0.02%)}	_~	_2,361,582k	_2,362,732k	_{p=0.575 n=6}
_{Parse Time}	_{5.24s (± 0.63%)}	_{5.23s (± 1.32%)}	_~	_5.16s	_5.36s	_{p=0.688 n=6}
_{Bind Time}	_{1.78s (± 1.49%)}	_{1.78s (± 0.87%)}	_~	_1.75s	_1.79s	_{p=0.746 n=6}
_{Check Time}	_{35.35s (± 0.41%)}	_{35.37s (± 0.50%)}	_~	_35.20s	_35.68s	_{p=0.872 n=6}
_{Emit Time}	_{3.03s (± 1.29%)}	_{3.02s (± 1.30%)}	_~	_2.98s	_3.09s	_{p=1.000 n=6}
_{Total Time}	_{45.39s (± 0.41%)}	_{45.40s (± 0.55%)}	_~	_45.15s	_45.84s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,795,780k (±14.25%)}	_{3,038,799k (± 9.77%)}	_~	_2,431,990k	_3,160,646k	_{p=0.093 n=6}
_{Parse Time}	_{8.60s (± 1.88%)}	_{8.68s (± 1.22%)}	_~	_8.52s	_8.81s	_{p=0.378 n=6}
_{Bind Time}	_{2.67s (± 1.00%)}	_{2.68s (± 1.61%)}	_~	_2.63s	_2.75s	_{p=0.871 n=6}
_{Check Time}	_{53.09s (± 0.39%)}	_{53.27s (± 0.73%)}	_~	_52.53s	_53.59s	_{p=0.173 n=6}
_{Emit Time}	_{4.42s (± 2.38%)}	_{4.39s (± 1.60%)}	_~	_4.27s	_4.48s	_{p=0.470 n=6}
_{Total Time}	_{68.77s (± 0.49%)}	_{69.01s (± 0.62%)}	_~	_68.20s	_69.41s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,311k (± 0.02%)}	_{441,318k (± 0.02%)}	_~	_441,226k	_441,396k	_{p=1.000 n=6}
_{Parse Time}	_{3.57s (± 1.25%)}	_{3.56s (± 0.57%)}	_~	_3.55s	_3.60s	_{p=0.683 n=6}
_{Bind Time}	_{1.31s (± 1.12%)}	_{1.32s (± 0.80%)}	_~	_1.30s	_1.33s	_{p=0.619 n=6}
_{Check Time}	_{18.98s (± 0.29%)}	_{19.00s (± 0.61%)}	_~	_18.79s	_19.10s	_{p=0.418 n=6}
_{Emit Time}	_{1.52s (± 1.47%)}	_{1.53s (± 1.13%)}	_~	_1.51s	_1.55s	_{p=0.316 n=6}
_{Total Time}	_{25.38s (± 0.18%)}	_{25.41s (± 0.50%)}	_~	_25.19s	_25.52s	_{p=0.469 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,836k (± 0.06%)}	_{371,739k (± 0.02%)}	_~	_371,664k	_371,826k	_{p=0.936 n=6}
_{Parse Time}	_{2.92s (± 1.44%)}	_{2.91s (± 1.02%)}	_~	_2.87s	_2.95s	_{p=0.462 n=6}
_{Bind Time}	_{1.61s (± 1.54%)}	_{1.60s (± 1.77%)}	_~	_1.57s	_1.65s	_{p=0.628 n=6}
_{Check Time}	_{16.47s (± 0.25%)}	_{16.52s (± 0.52%)}	_~	_16.46s	_16.68s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.00s (± 0.42%)}	_{21.02s (± 0.45%)}	_~	_20.92s	_21.19s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₅	_{🔻+2 (+66.67%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,272,443	_3,272,445	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,125,152	_1,125,154	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,346,538k (± 0.01%)}	_{3,346,589k (± 0.01%)}	_~	_3,346,360k	_3,347,042k	_{p=0.471 n=6}
_{Parse Time}	_{14.59s (± 0.33%)}	_{14.59s (± 0.54%)}	_~	_14.53s	_14.71s	_{p=0.747 n=6}
_{Bind Time}	_{4.60s (± 0.39%)}	_{4.60s (± 0.40%)}	_~	_4.58s	_4.63s	_{p=0.743 n=6}
_{Check Time}	_{91.64s (± 2.97%)}	_{91.55s (± 2.94%)}	_~	_88.61s	_96.34s	_{p=0.873 n=6}
_{Emit Time}	_{28.43s (± 3.19%)}	_{28.18s (± 9.19%)}	_~	_23.13s	_30.00s	_{p=0.298 n=6}
_{Total Time}	_{139.26s (± 2.18%)}	_{138.93s (± 0.80%)}	_~	_137.46s	_140.30s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_292,550	_292,552	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_119,124	_119,125	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{446,037k (± 0.04%)}	_{446,115k (± 0.03%)}	_~	_445,934k	_446,281k	_{p=0.471 n=6}
_{Parse Time}	_{5.08s (± 1.63%)}	_{5.07s (± 1.13%)}	_~	_4.99s	_5.15s	_{p=0.629 n=6}
_{Bind Time}	_{2.23s (± 0.93%)}	_{2.21s (± 0.88%)}	_{-0.03s (- 1.19%)}	_2.18s	_2.23s	_{p=0.043 n=6}
_{Check Time}	_{23.48s (± 1.61%)}	_{23.34s (± 0.31%)}	_~	_23.27s	_23.44s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.81s (± 1.12%)}	_{30.62s (± 0.25%)}	_~	_30.50s	_30.71s	_{p=0.126 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,449	_555,448	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,540k (± 0.03%)}	_{494,545k (± 0.03%)}	_~	_494,257k	_494,632k	_{p=1.000 n=6}
_{Parse Time}	_{3.41s (± 0.94%)}	_{3.41s (± 0.60%)}	_~	_3.39s	_3.44s	_{p=0.806 n=6}
_{Bind Time}	_{1.21s (± 1.00%)}	_{1.21s (± 1.34%)}	_~	_1.19s	_1.23s	_{p=0.462 n=6}
_{Check Time}	_{19.68s (± 0.83%)}	_{19.75s (± 2.15%)}	_~	_19.50s	_20.61s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.30s (± 0.69%)}	_{24.37s (± 1.76%)}	_~	_24.10s	_25.24s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-29T17:34:27Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

typescript-bot · 2025-01-29T18:29:19Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61073/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2416: Property 'onmessage' in type 'NestedWorker' is not assignable to the same property in base type 'Worker'.
- src/vs/workbench/services/extensions/worker/polyfillNestedWorker.ts#L59
error TS2416: Property 'onmessageerror' in type 'NestedWorker' is not assignable to the same property in base type 'Worker'.
- src/vs/workbench/services/extensions/worker/polyfillNestedWorker.ts#L60

extensions/json-language-features/server/tsconfig.json

error TS2345: Argument of type 'WorkerGlobalScope & typeof globalThis' is not assignable to parameter of type 'MessagePort | Worker | DedicatedWorkerGlobalScope'.
- extensions/json-language-features/server/src/browser/jsonServerMain.ts#L10
- extensions/json-language-features/server/src/browser/jsonServerMain.ts#L11
error TS2684: The 'this' context of type 'WorkerGlobalScope & typeof globalThis' is not assignable to method's 'this' of type 'DedicatedWorkerGlobalScope'.
- extensions/json-language-features/server/src/browser/jsonServerWorkerMain.ts#L27

extensions/html-language-features/server/tsconfig.json

error TS2345: Argument of type 'WorkerGlobalScope & typeof globalThis' is not assignable to parameter of type 'MessagePort | Worker | DedicatedWorkerGlobalScope'.
- extensions/html-language-features/server/src/browser/htmlServerMain.ts#L9
- extensions/html-language-features/server/src/browser/htmlServerMain.ts#L10
error TS2684: The 'this' context of type 'WorkerGlobalScope & typeof globalThis' is not assignable to method's 'this' of type 'DedicatedWorkerGlobalScope'.
- extensions/html-language-features/server/src/browser/htmlServerWorkerMain.ts#L27

extensions/css-language-features/server/tsconfig.json

error TS2345: Argument of type 'WorkerGlobalScope & typeof globalThis' is not assignable to parameter of type 'MessagePort | Worker | DedicatedWorkerGlobalScope'.
- extensions/css-language-features/server/src/browser/cssServerMain.ts#L9
- extensions/css-language-features/server/src/browser/cssServerMain.ts#L10
error TS2684: The 'this' context of type 'WorkerGlobalScope & typeof globalThis' is not assignable to method's 'this' of type 'DedicatedWorkerGlobalScope'.
- extensions/css-language-features/server/src/browser/cssServerWorkerMain.ts#L27

sandersn · 2025-01-29T18:43:28Z

No new failures from this update, which means that it's good to merge.

However, rusha and vscode are failing with the MessagePort-related error that I thought was fixed. I need to see what's going on there.

See if it fixes DT/vscode compilation

sandersn · 2025-01-29T18:58:51Z

@typescript-bot test this

typescript-bot · 2025-01-29T18:58:56Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-29T19:18:51Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

typescript-bot · 2025-01-29T19:21:31Z

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: rusha
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rusha/index.d.ts
  19:11  error  TypeScript@local compile error: 
Interface 'RushaWorker' incorrectly extends interface 'Worker'.
  Types of property 'onmessage' are incompatible.
    Type '((this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void) | null' is not assignable to type '((this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any) | null'.
      Type '(this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void' is not assignable to type '(this: MessageEventTarget<Worker>, ev: MessageEvent<any>) => any'.
        The 'this' types of each signature are incompatible.
          Type 'MessageEventTarget<Worker>' is missing the following properties from type 'RushaWorker': postMessage, terminate, dispatchEvent, onerror  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<void>', but here has type 'Promise<undefined>'               @definitelytyped/expect
  7:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<void>', but here has type 'Promise<undefined>'            @definitelytyped/expect
  8:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<void>', but here has type 'Promise<undefined>'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Errors that changed between main and the branch:

Package: dom-webcodecs
Main error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Branch error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  505:6  error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2025-01-29T19:44:14Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,777k (± 0.81%)}	_{194,421k (± 0.96%)}	_~	_193,111k	_196,830k	_{p=0.630 n=6}
_{Parse Time}	_{1.31s (± 0.39%)}	_{1.30s (± 1.43%)}	_~	_1.28s	_1.32s	_{p=0.796 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.78s (± 0.32%)}	_{9.77s (± 0.22%)}	_~	_9.74s	_9.80s	_{p=0.466 n=6}
_{Emit Time}	_{2.72s (± 0.49%)}	_{2.74s (± 0.43%)}	_{+0.02s (+ 0.73%)}	_2.72s	_2.75s	_{p=0.027 n=6}
_{Total Time}	_{14.54s (± 0.27%)}	_{14.54s (± 0.12%)}	_~	_14.52s	_14.56s	_{p=0.934 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,493	_948,494	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_411,005	_411,006	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,395k (± 0.00%)}	_{1,225,444k (± 0.00%)}	_~	_1,225,385k	_1,225,505k	_{p=0.128 n=6}
_{Parse Time}	_{6.67s (± 0.36%)}	_{6.62s (± 1.10%)}	_~	_6.51s	_6.69s	_{p=0.293 n=6}
_{Bind Time}	_{1.88s (± 1.03%)}	_{1.89s (± 0.99%)}	_~	_1.87s	_1.92s	_{p=0.681 n=6}
_{Check Time}	_{31.99s (± 0.43%)}	_{31.93s (± 0.30%)}	_~	_31.81s	_32.06s	_{p=0.423 n=6}
_{Emit Time}	_{15.17s (± 0.24%)}	_{15.24s (± 0.45%)}	_~	_15.12s	_15.31s	_{p=0.089 n=6}
_{Total Time}	_{55.71s (± 0.31%)}	_{55.67s (± 0.20%)}	_~	_55.53s	_55.78s	_{p=0.468 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,050	_2,447,054	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_898,533	_898,533	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,897k (± 0.00%)}	_{2,307,963k (± 0.00%)}	_~	_2,307,752k	_2,308,043k	_{p=0.078 n=6}
_{Parse Time}	_{13.28s (± 0.78%)}	_{13.29s (± 0.42%)}	_~	_13.18s	_13.33s	_{p=0.809 n=6}
_{Bind Time}	_{3.23s (± 0.91%)}	_{3.23s (± 0.61%)}	_~	_3.20s	_3.25s	_{p=0.935 n=6}
_{Check Time}	_{109.78s (± 1.26%)}	_{110.10s (± 1.80%)}	_~	_108.61s	_112.90s	_{p=0.689 n=6}
_{Emit Time}	_{0.42s (± 1.80%)}	_{0.42s (± 2.13%)}	_~	_0.41s	_0.43s	_{p=0.798 n=6}
_{Total Time}	_{126.71s (± 1.14%)}	_{127.04s (± 1.58%)}	_~	_125.55s	_129.85s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,362,515k (± 0.02%)}	_{2,362,209k (± 0.02%)}	_~	_2,361,817k	_2,362,851k	_{p=0.298 n=6}
_{Parse Time}	_{5.22s (± 1.03%)}	_{5.22s (± 1.05%)}	_~	_5.15s	_5.28s	_{p=1.000 n=6}
_{Bind Time}	_{1.80s (± 0.30%)}	_{1.79s (± 0.96%)}	_~	_1.77s	_1.82s	_{p=0.498 n=6}
_{Check Time}	_{35.27s (± 0.30%)}	_{35.26s (± 0.30%)}	_~	_35.09s	_35.42s	_{p=0.872 n=6}
_{Emit Time}	_{3.02s (± 1.25%)}	_{3.01s (± 1.06%)}	_~	_2.97s	_3.06s	_{p=0.573 n=6}
_{Total Time}	_{45.32s (± 0.34%)}	_{45.28s (± 0.17%)}	_~	_45.16s	_45.36s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,038,711k (± 9.75%)}	_{3,038,677k (± 9.75%)}	_~	_2,433,341k	_3,160,463k	_{p=1.000 n=6}
_{Parse Time}	_{7.01s (± 1.43%)}	_{7.00s (± 1.02%)}	_~	_6.88s	_7.06s	_{p=1.000 n=6}
_{Bind Time}	_{2.15s (± 1.91%)}	_{2.15s (± 1.27%)}	_~	_2.10s	_2.17s	_{p=1.000 n=6}
_{Check Time}	_{43.02s (± 0.51%)}	_{42.90s (± 0.44%)}	_~	_42.62s	_43.09s	_{p=0.423 n=6}
_{Emit Time}	_{3.46s (± 2.16%)}	_{3.48s (± 1.50%)}	_~	_3.42s	_3.56s	_{p=0.575 n=6}
_{Total Time}	_{55.65s (± 0.53%)}	_{55.53s (± 0.45%)}	_~	_55.08s	_55.74s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,324k (± 0.01%)}	_{441,298k (± 0.01%)}	_~	_441,261k	_441,378k	_{p=0.378 n=6}
_{Parse Time}	_{3.55s (± 0.61%)}	_{3.57s (± 1.35%)}	_~	_3.50s	_3.64s	_{p=0.617 n=6}
_{Bind Time}	_{1.31s (± 0.48%)}	_{1.32s (± 0.88%)}	_~	_1.31s	_1.34s	_{p=0.070 n=6}
_{Check Time}	_{19.02s (± 0.33%)}	_{19.04s (± 0.51%)}	_~	_18.91s	_19.19s	_{p=0.747 n=6}
_{Emit Time}	_{1.53s (± 1.35%)}	_{1.53s (± 1.09%)}	_~	_1.51s	_1.55s	_{p=0.737 n=6}
_{Total Time}	_{25.41s (± 0.23%)}	_{25.46s (± 0.51%)}	_~	_25.24s	_25.60s	_{p=0.336 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,729k (± 0.01%)}	_{371,798k (± 0.03%)}	_~	_371,712k	_371,986k	_{p=0.199 n=6}
_{Parse Time}	_{3.62s (± 0.54%)}	_{3.62s (± 0.78%)}	_~	_3.59s	_3.66s	_{p=0.870 n=6}
_{Bind Time}	_{1.98s (± 0.45%)}	_{1.97s (± 1.00%)}	_~	_1.94s	_2.00s	_{p=0.119 n=6}
_{Check Time}	_{20.45s (± 0.33%)}	_{20.45s (± 0.38%)}	_~	_20.37s	_20.56s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{26.06s (± 0.26%)}	_{26.04s (± 0.31%)}	_~	_25.95s	_26.14s	_{p=0.630 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₅	_{🔻+2 (+66.67%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,272,246	_3,272,250	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,125,114	_1,125,116	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,346,744k (± 0.01%)}	_{3,346,624k (± 0.01%)}	_~	_3,346,161k	_3,346,913k	_{p=0.298 n=6}
_{Parse Time}	_{14.60s (± 0.33%)}	_{14.47s (± 0.65%)}	_{-0.13s (- 0.87%)}	_14.37s	_14.63s	_{p=0.037 n=6}
_{Bind Time}	_{4.60s (± 2.17%)}	_{4.63s (± 2.75%)}	_~	_4.52s	_4.80s	_{p=0.936 n=6}
_{Check Time}	_{90.32s (± 1.46%)}	_{89.51s (± 2.16%)}	_~	_87.78s	_92.25s	_{p=0.471 n=6}
_{Emit Time}	_{26.99s (± 7.48%)}	_{27.56s (± 7.94%)}	_~	_23.42s	_29.43s	_{p=0.575 n=6}
_{Total Time}	_{136.51s (± 1.12%)}	_{136.17s (± 1.46%)}	_~	_134.20s	_139.40s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_292,550	_292,554	_{+4 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_119,124	_119,125	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{446,132k (± 0.02%)}	_{446,063k (± 0.02%)}	_~	_445,973k	_446,232k	_{p=0.230 n=6}
_{Parse Time}	_{4.10s (± 0.86%)}	_{4.08s (± 0.83%)}	_~	_4.04s	_4.13s	_{p=0.373 n=6}
_{Bind Time}	_{1.78s (± 1.05%)}	_{1.78s (± 1.11%)}	_~	_1.75s	_1.80s	_{p=0.684 n=6}
_{Check Time}	_{18.78s (± 0.42%)}	_{18.78s (± 0.23%)}	_~	_18.72s	_18.85s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.67s (± 0.24%)}	_{24.64s (± 0.13%)}	_~	_24.61s	_24.69s	_{p=0.372 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,449	_555,450	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,586k (± 0.01%)}	_{494,613k (± 0.01%)}	_~	_494,506k	_494,711k	_{p=0.689 n=6}
_{Parse Time}	_{3.41s (± 0.81%)}	_{3.42s (± 0.31%)}	_~	_3.40s	_3.43s	_{p=0.324 n=6}
_{Bind Time}	_{1.22s (± 1.27%)}	_{1.22s (± 1.27%)}	_~	_1.20s	_1.24s	_{p=0.931 n=6}
_{Check Time}	_{19.67s (± 0.39%)}	_{19.69s (± 0.33%)}	_~	_19.61s	_19.78s	_{p=0.687 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.30s (± 0.27%)}	_{24.32s (± 0.28%)}	_~	_24.25s	_24.43s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-29T20:37:06Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61073/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2416: Property 'onmessage' in type 'NestedWorker' is not assignable to the same property in base type 'Worker'.
- src/vs/workbench/services/extensions/worker/polyfillNestedWorker.ts#L59
error TS2416: Property 'onmessageerror' in type 'NestedWorker' is not assignable to the same property in base type 'Worker'.
- src/vs/workbench/services/extensions/worker/polyfillNestedWorker.ts#L60

extensions/json-language-features/server/tsconfig.json

error TS2345: Argument of type 'WorkerGlobalScope & typeof globalThis' is not assignable to parameter of type 'MessagePort | Worker | DedicatedWorkerGlobalScope'.
- extensions/json-language-features/server/src/browser/jsonServerMain.ts#L10
- extensions/json-language-features/server/src/browser/jsonServerMain.ts#L11
error TS2684: The 'this' context of type 'WorkerGlobalScope & typeof globalThis' is not assignable to method's 'this' of type 'DedicatedWorkerGlobalScope'.
- extensions/json-language-features/server/src/browser/jsonServerWorkerMain.ts#L27

extensions/html-language-features/server/tsconfig.json

error TS2345: Argument of type 'WorkerGlobalScope & typeof globalThis' is not assignable to parameter of type 'MessagePort | Worker | DedicatedWorkerGlobalScope'.
- extensions/html-language-features/server/src/browser/htmlServerMain.ts#L9
- extensions/html-language-features/server/src/browser/htmlServerMain.ts#L10
error TS2684: The 'this' context of type 'WorkerGlobalScope & typeof globalThis' is not assignable to method's 'this' of type 'DedicatedWorkerGlobalScope'.
- extensions/html-language-features/server/src/browser/htmlServerWorkerMain.ts#L27

extensions/css-language-features/server/tsconfig.json

error TS2345: Argument of type 'WorkerGlobalScope & typeof globalThis' is not assignable to parameter of type 'MessagePort | Worker | DedicatedWorkerGlobalScope'.
- extensions/css-language-features/server/src/browser/cssServerMain.ts#L9
- extensions/css-language-features/server/src/browser/cssServerMain.ts#L10
error TS2684: The 'this' context of type 'WorkerGlobalScope & typeof globalThis' is not assignable to method's 'this' of type 'DedicatedWorkerGlobalScope'.
- extensions/css-language-features/server/src/browser/cssServerWorkerMain.ts#L27

sandersn · 2025-01-29T22:06:55Z

Re-adding the members of WorkerEventMap didn't help. We should merge this PR after I revert that commit, and I'll figure out the problem separately.

This reverts commit 1a3d836.

sandersn · 2025-01-30T14:47:35Z

@typescript-bot test this

typescript-bot · 2025-01-30T14:47:44Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started
`user test this`	✅ Started
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	❌ Results

typescript-bot · 2025-01-30T14:52:35Z

@sandersn, the perf run you requested failed. You can check the log here.

typescript-bot · 2025-01-30T15:11:25Z

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<undefined>
got:
  Promise<void>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<void>', but here has type 'Promise<undefined>'               @definitelytyped/expect
  7:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<void>', but here has type 'Promise<undefined>'            @definitelytyped/expect
  8:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<void>', but here has type 'Promise<undefined>'  @definitelytyped/expect

✖ 6 problems (6 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Errors that changed between main and the branch:

Package: dom-webcodecs
Main error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Branch error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  505:6  error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

sandersn · 2025-01-30T16:52:26Z

rusha is fixed, which is indicative that vscode will also be fixed when I can get a run of it.

jakebailey · 2025-01-30T17:52:17Z

@typescript-bot test top400
@typescript-bot user test this
@typescript-bot perf test this faster

typescript-bot · 2025-01-30T17:52:22Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-30T18:14:44Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

typescript-bot · 2025-01-30T18:48:12Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,854k (± 0.12%)}	_{195,650k (± 0.93%)}	_~	_193,295k	_196,949k	_{p=0.173 n=6}
_{Parse Time}	_{1.61s (± 0.88%)}	_{1.60s (± 1.88%)}	_~	_1.54s	_1.62s	_{p=0.568 n=6}
_{Bind Time}	_{0.88s (± 0.86%)}	_{0.88s (± 0.85%)}	_~	_0.87s	_0.89s	_{p=0.487 n=6}
_{Check Time}	_{11.83s (± 0.82%)}	_{11.78s (± 0.44%)}	_~	_11.69s	_11.84s	_{p=0.687 n=6}
_{Emit Time}	_{3.31s (± 1.25%)}	_{3.33s (± 2.93%)}	_~	_3.26s	_3.52s	_{p=0.810 n=6}
_{Total Time}	_{17.63s (± 0.71%)}	_{17.59s (± 0.79%)}	_~	_17.37s	_17.80s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,493	_948,488	_{-5 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_411,005	_411,006	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,225,473k (± 0.00%)}	_{1,225,472k (± 0.00%)}	_~	_1,225,412k	_1,225,542k	_{p=0.936 n=6}
_{Parse Time}	_{6.65s (± 0.90%)}	_{6.63s (± 1.01%)}	_~	_6.54s	_6.70s	_{p=0.572 n=6}
_{Bind Time}	_{1.89s (± 0.43%)}	_{1.89s (± 0.91%)}	_~	_1.86s	_1.91s	_{p=0.677 n=6}
_{Check Time}	_{32.03s (± 0.15%)}	_{31.95s (± 0.37%)}	_~	_31.77s	_32.10s	_{p=0.226 n=6}
_{Emit Time}	_{15.21s (± 0.58%)}	_{15.17s (± 0.42%)}	_~	_15.10s	_15.27s	_{p=0.574 n=6}
_{Total Time}	_{55.78s (± 0.18%)}	_{55.64s (± 0.39%)}	_~	_55.29s	_55.82s	_{p=0.166 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,081	_2,447,083	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_898,548	_898,548	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,308,046k (± 0.00%)}	_{2,308,049k (± 0.01%)}	_~	_2,307,823k	_2,308,213k	_{p=0.810 n=6}
_{Parse Time}	_{10.75s (± 0.33%)}	_{10.79s (± 0.34%)}	_~	_10.75s	_10.86s	_{p=0.090 n=6}
_{Bind Time}	_{2.63s (± 0.83%)}	_{2.63s (± 0.92%)}	_~	_2.60s	_2.66s	_{p=0.868 n=6}
_{Check Time}	_{89.05s (± 0.75%)}	_{88.94s (± 0.35%)}	_~	_88.59s	_89.34s	_{p=0.471 n=6}
_{Emit Time}	_{0.35s (± 2.35%)}	_{0.72s (±127.11%)}	_~	_0.34s	_2.59s	_{p=0.796 n=6}
_{Total Time}	_{102.78s (± 0.67%)}	_{103.08s (± 0.97%)}	_~	_102.30s	_105.02s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,362,265k (± 0.01%)}	_{2,362,084k (± 0.02%)}	_~	_2,361,171k	_2,362,737k	_{p=0.810 n=6}
_{Parse Time}	_{5.26s (± 0.48%)}	_{5.23s (± 0.88%)}	_~	_5.18s	_5.30s	_{p=0.520 n=6}
_{Bind Time}	_{1.80s (± 0.65%)}	_{1.78s (± 1.04%)}	_~	_1.76s	_1.81s	_{p=0.105 n=6}
_{Check Time}	_{35.26s (± 0.39%)}	_{35.28s (± 0.25%)}	_~	_35.16s	_35.42s	_{p=1.000 n=6}
_{Emit Time}	_{3.02s (± 1.63%)}	_{2.99s (± 1.34%)}	_~	_2.92s	_3.04s	_{p=0.260 n=6}
_{Total Time}	_{45.33s (± 0.25%)}	_{45.29s (± 0.17%)}	_~	_45.19s	_45.42s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,429,394k (± 0.01%)}	_{2,429,233k (± 0.02%)}	_~	_2,428,731k	_2,429,717k	_{p=0.471 n=6}
_{Parse Time}	_{5.43s (± 0.97%)}	_{5.47s (± 0.65%)}	_~	_5.42s	_5.52s	_{p=0.297 n=6}
_{Bind Time}	_{1.77s (± 0.29%)}	_{1.80s (± 1.15%)}	_{+0.03s (+ 1.60%)}	_1.77s	_1.82s	_{p=0.021 n=6}
_{Check Time}	_{35.31s (± 0.26%)}	_{35.30s (± 0.35%)}	_~	_35.15s	_35.47s	_{p=0.936 n=6}
_{Emit Time}	_{3.06s (± 0.96%)}	_{3.08s (± 1.71%)}	_~	_3.01s	_3.15s	_{p=0.936 n=6}
_{Total Time}	_{45.59s (± 0.28%)}	_{45.64s (± 0.29%)}	_~	_45.47s	_45.83s	_{p=0.575 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,359k (± 0.03%)}	_{441,311k (± 0.00%)}	_~	_441,292k	_441,326k	_{p=0.936 n=6}
_{Parse Time}	_{2.91s (± 0.43%)}	_{2.90s (± 0.74%)}	_~	_2.87s	_2.93s	_{p=0.453 n=6}
_{Bind Time}	_1.11s	_1.11s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{15.81s (± 0.49%)}	_{15.85s (± 0.25%)}	_~	_15.79s	_15.90s	_{p=0.261 n=6}
_{Emit Time}	_{1.32s (± 1.39%)}	_{1.32s (± 0.80%)}	_~	_1.30s	_1.33s	_{p=0.324 n=6}
_{Total Time}	_{21.15s (± 0.39%)}	_{21.17s (± 0.28%)}	_~	_21.11s	_21.26s	_{p=0.575 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,734k (± 0.01%)}	_{371,928k (± 0.07%)}	_~	_371,712k	_372,387k	_{p=0.078 n=6}
_{Parse Time}	_{3.62s (± 0.64%)}	_{3.59s (± 1.23%)}	_~	_3.53s	_3.64s	_{p=0.375 n=6}
_{Bind Time}	_{1.97s (± 1.55%)}	_{1.97s (± 0.94%)}	_~	_1.96s	_2.01s	_{p=0.871 n=6}
_{Check Time}	_{20.44s (± 0.24%)}	_{20.45s (± 0.18%)}	_~	_20.41s	_20.50s	_{p=0.623 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{26.03s (± 0.30%)}	_{26.03s (± 0.24%)}	_~	_25.95s	_26.13s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,273,248	_3,273,250	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,125,534	_1,125,536	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,347,429k (± 0.01%)}	_{3,347,223k (± 0.01%)}	_~	_3,346,899k	_3,347,614k	_{p=0.689 n=6}
_{Parse Time}	_{18.03s (± 0.37%)}	_{18.01s (± 0.55%)}	_~	_17.90s	_18.19s	_{p=0.422 n=6}
_{Bind Time}	_{5.62s (± 0.50%)}	_{5.62s (± 0.29%)}	_~	_5.60s	_5.64s	_{p=1.000 n=6}
_{Check Time}	_{108.03s (± 0.33%)}	_{109.42s (± 1.61%)}	_~	_107.75s	_112.04s	_{p=0.093 n=6}
_{Emit Time}	_{34.13s (± 2.08%)}	_{34.98s (± 2.63%)}	_~	_33.70s	_35.79s	_{p=0.173 n=6}
_{Total Time}	_{165.82s (± 0.52%)}	_{168.02s (± 1.17%)}	_{+2.20s (+ 1.33%)}	_165.75s	_171.44s	_{p=0.020 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_292,550	_292,552	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_119,124	_119,125	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{446,150k (± 0.02%)}	_{446,176k (± 0.03%)}	_~	_445,996k	_446,398k	_{p=0.936 n=6}
_{Parse Time}	_{4.10s (± 0.85%)}	_{4.10s (± 1.08%)}	_~	_4.05s	_4.16s	_{p=0.872 n=6}
_{Bind Time}	_{1.78s (± 1.03%)}	_{1.79s (± 0.67%)}	_~	_1.78s	_1.81s	_{p=0.323 n=6}
_{Check Time}	_{18.84s (± 0.42%)}	_{18.87s (± 0.41%)}	_~	_18.79s	_18.98s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.73s (± 0.46%)}	_{24.76s (± 0.40%)}	_~	_24.65s	_24.92s	_{p=0.688 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,449	_555,448	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,592k (± 0.01%)}	_{494,594k (± 0.01%)}	_~	_494,537k	_494,644k	_{p=0.689 n=6}
_{Parse Time}	_{3.42s (± 0.50%)}	_{3.42s (± 0.32%)}	_~	_3.40s	_3.43s	_{p=0.933 n=6}
_{Bind Time}	_{1.20s (± 0.68%)}	_{1.20s (± 1.55%)}	_~	_1.17s	_1.22s	_{p=0.739 n=6}
_{Check Time}	_{19.67s (± 0.47%)}	_{19.73s (± 0.40%)}	_~	_19.61s	_19.82s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.29s (± 0.38%)}	_{24.35s (± 0.37%)}	_~	_24.23s	_24.46s	_{p=0.336 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-30T19:28:16Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61073/merge:

Everything looks good!

sandersn · 2025-01-30T19:34:04Z

OK, I think everything is ready here, although I need to go fix the output of DOM-lib-generator to be this: T in the right places.

DOM update 2025/01/29

d3fbb1a

This is going into nightly to make sure that microsoft/TypeScript-DOM-lib-generator#1598 is goodto ship for the RC.

Manually put WorkerEventMap members back

1a3d836

See if it fixes DT/vscode compilation

sandersn added 2 commits January 29, 2025 14:07

Revert "Manually put WorkerEventMap members back"

6cdaacd

This reverts commit 1a3d836.

restore this: T

b2de5f0

typescript-bot assigned sandersn Jan 30, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 30, 2025

jakebailey approved these changes Jan 30, 2025

View reviewed changes

sandersn merged commit 66e1b24 into microsoft:main Jan 30, 2025
32 checks passed

sandersn deleted the dom-update-2025-01-29 branch January 30, 2025 19:39

DOM update 2025/01/29 #61073

DOM update 2025/01/29 #61073

Conversation

sandersn commented Jan 29, 2025 • edited Loading

sandersn commented Jan 29, 2025

typescript-bot commented Jan 29, 2025 • edited Loading

typescript-bot commented Jan 29, 2025

jakebailey commented Jan 29, 2025

typescript-bot commented Jan 29, 2025 • edited Loading

typescript-bot commented Jan 29, 2025

tsc

typescript-bot commented Jan 29, 2025

typescript-bot commented Jan 29, 2025

sandersn commented Jan 29, 2025

sandersn commented Jan 29, 2025

typescript-bot commented Jan 29, 2025 • edited Loading

typescript-bot commented Jan 29, 2025

typescript-bot commented Jan 29, 2025

typescript-bot commented Jan 29, 2025

tsc

typescript-bot commented Jan 29, 2025

sandersn commented Jan 29, 2025

sandersn commented Jan 30, 2025

typescript-bot commented Jan 30, 2025 • edited Loading

typescript-bot commented Jan 30, 2025

typescript-bot commented Jan 30, 2025

sandersn commented Jan 30, 2025

jakebailey commented Jan 30, 2025

typescript-bot commented Jan 30, 2025 • edited Loading

typescript-bot commented Jan 30, 2025

typescript-bot commented Jan 30, 2025

tsc

typescript-bot commented Jan 30, 2025

sandersn commented Jan 30, 2025

sandersn commented Jan 29, 2025 •

edited

Loading

typescript-bot commented Jan 29, 2025 •

edited

Loading

typescript-bot commented Jan 29, 2025 •

edited

Loading

typescript-bot commented Jan 29, 2025 •

edited

Loading

typescript-bot commented Jan 30, 2025 •

edited

Loading

typescript-bot commented Jan 30, 2025 •

edited

Loading