Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for Object.entries/Object.fromEntries #61074

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix types for Object.entries/Object.fromEntries #61074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2264e
feat: update Object.entries types
nezo32 Jan 29, 2025
d3471e2
feat: update Object.fromEntries types
nezo32 Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/es2017.object.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface ObjectConstructor {
* Returns an array of key/values of the enumerable own properties of an object
* @param o Object that contains the properties and methods. This can be an object that you created or an existing Document Object Model (DOM) object.
*/
entries<T>(o: { [s: string]: T; } | ArrayLike<T>): [string, T][];
entries<T, K extends string = string>(o: { [Key in K]: T; } | ArrayLike<T>): [K, T][];

/**
* Returns an array of key/values of the enumerable own properties of an object
Expand Down
2 changes: 1 addition & 1 deletion src/lib/es2019.object.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ interface ObjectConstructor {
* Returns an object created by key-value entries for properties and methods
* @param entries An iterable object that contains key-value entries for properties and methods.
*/
fromEntries<T = any>(entries: Iterable<readonly [PropertyKey, T]>): { [k: string]: T; };
fromEntries<T = any, K extends PropertyKey = PropertyKey>(entries: Iterable<readonly [K, T]>): { [Key in K]: T; };

/**
* Returns an object created by key-value entries for properties and methods
Expand Down
Loading