Skip to content

Move unreachable checks to checker #62751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 14, 2025
Merged

Move unreachable checks to checker #62751

merged 13 commits into from
Nov 14, 2025

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Nov 13, 2025 •
edited
Loading

This ports microsoft/typescript-go#2067 to this repo. See that PR for a longer write-up.

This is technically a breaking change, as these diagnostics are no longer automatically provided on bound files. But, you'd be silly to rely solely on the binder diagnostics for this info when the checker does even more unreachable checks using type info. So, I doubt anyone's doing that.

Not in this PR is changing the option declaration to make these not marked as source file affecting; have not looked into that (tsgo does not use that info at all).

Closes #55588
Fixes #55562

Copilot AI review requested due to automatic review settings November 13, 2025 05:15
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Nov 13, 2025
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 13, 2025
@jakebailey
Copy link
Member Author

jakebailey commented Nov 13, 2025

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

Copilot finished reviewing on behalf of jakebailey November 13, 2025 05:16
Copilot AI reviewed Nov 13, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves unreachability checks from the binder to the checker phase of compilation. Previously, unreachable code detection happened during binding and generated diagnostics immediately. Now, the binder marks nodes as unreachable using a flag, and the checker generates diagnostics when visiting those nodes. This allows for more flexible diagnostic reporting (errors vs suggestions) and better handling of consecutive unreachable statements.

Key Changes:

  • Added NodeFlags.Unreachable flag to mark unreachable nodes during binding
  • Moved diagnostic generation for unreachable code from binder to checker
  • Improved handling of consecutive unreachable statements by reporting them as a single diagnostic range

Reviewed Changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/compiler/types.ts Added Unreachable flag to NodeFlags enum
src/compiler/binder.ts Removed unreachability diagnostic logic; now only marks nodes as unreachable via flags
src/compiler/checker.ts Added logic to detect and report unreachable code diagnostics based on flags set by binder
tests/cases/fourslash/*.ts Updated tests to expect suggestion diagnostics instead of no diagnostics when unreachable code is allowed
tests/cases/compiler/reachabilityChecks*.ts Added new test cases for unreachable code detection in various scenarios
tests/baselines/reference/*.txt Updated baseline files to reflect new diagnostic reporting behavior
Comments suppressed due to low confidence (1)

src/compiler/checker.ts:1

  • [nitpick] The inline boolean comments for skipTrivia parameters are unclear. Consider adding a comment explaining why we stop at comments but not at line breaks, or use named parameters if possible.

@jakebailey jakebailey mentioned this pull request Nov 13, 2025
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166521/artifacts?artifactName=tgz&fileId=60CD29EDE69768CD3E3ECE8E475520E9F0B824BAE54816A6BD15401624EE048402&fileName=/typescript-6.0.0-insiders.20251113.tgz"
    }
}

and then running npm install.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62751/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 194,545k (± 0.99%) 194,003k (± 0.91%) ~ 192,651k 196,324k p=0.689 n=6
Parse Time 1.30s (± 0.58%) 1.30s (± 0.75%) ~ 1.29s 1.31s p=1.000 n=6
Bind Time 0.72s 0.73s (± 0.56%) +0.01s (+ 1.62%) 0.73s 0.74s p=0.002 n=6
Check Time 9.88s (± 0.36%) 9.88s (± 0.15%) ~ 9.86s 9.90s p=1.000 n=6
Emit Time 2.75s (± 0.19%) 2.74s (± 1.21%) ~ 2.70s 2.78s p=1.000 n=6
Total Time 14.65s (± 0.31%) 14.66s (± 0.22%) ~ 14.60s 14.69s p=0.572 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 956,047 956,047 ~ ~ ~ p=1.000 n=6
Types 415,881 415,881 ~ ~ ~ p=1.000 n=6
Memory used 1,255,060k (± 0.00%) 1,254,986k (± 0.00%) ~ 1,254,943k 1,255,068k p=0.066 n=6
Parse Time 6.52s (± 0.69%) 6.56s (± 0.79%) ~ 6.47s 6.62s p=0.228 n=6
Bind Time 1.88s (± 0.34%) 1.93s (± 0.27%) +0.05s (+ 2.48%) 1.92s 1.93s p=0.004 n=6
Check Time 32.30s (± 0.27%) 32.29s (± 0.32%) ~ 32.17s 32.45s p=0.809 n=6
Emit Time 14.93s (± 0.24%) 14.94s (± 0.27%) ~ 14.87s 14.98s p=0.685 n=6
Total Time 55.63s (± 0.14%) 55.73s (± 0.14%) ~ 55.60s 55.78s p=0.053 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,661,428 2,661,428 ~ ~ ~ p=1.000 n=6
Types 921,362 921,362 ~ ~ ~ p=1.000 n=6
Memory used 2,972,671k (± 0.00%) 2,972,715k (± 0.00%) ~ 2,972,575k 2,972,789k p=0.298 n=6
Parse Time 8.39s (± 0.26%) 8.42s (± 0.23%) ~ 8.40s 8.45s p=0.220 n=6
Bind Time 2.18s (± 0.29%) 2.20s (± 0.60%) +0.02s (+ 0.84%) 2.19s 2.22s p=0.009 n=6
Check Time 91.62s (± 0.37%) 91.73s (± 0.31%) ~ 91.28s 92.04s p=0.689 n=6
Emit Time 0.31s (± 1.68%) 0.30s (± 1.79%) ~ 0.30s 0.31s p=0.640 n=6
Total Time 102.49s (± 0.33%) 102.64s (± 0.25%) ~ 102.23s 102.94s p=0.689 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,122 -156 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,801 -83 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 2,365,189k (± 0.02%) 2,365,143k (± 0.01%) ~ 2,364,719k 2,365,420k p=0.689 n=6
Parse Time 5.14s (± 0.63%) 5.10s (± 1.19%) ~ 5.02s 5.21s p=0.172 n=6
Bind Time 1.76s (± 0.47%) 1.81s (± 1.20%) +0.04s (+ 2.27%) 1.78s 1.84s p=0.006 n=6
Check Time 35.21s (± 0.23%) 35.37s (± 0.15%) +0.16s (+ 0.47%) 35.30s 35.44s p=0.013 n=6
Emit Time 2.99s (± 0.51%) 3.01s (± 0.72%) ~ 2.98s 3.04s p=0.107 n=6
Total Time 45.13s (± 0.22%) 45.31s (± 0.15%) +0.18s (+ 0.41%) 45.25s 45.43s p=0.005 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,122 -156 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,801 -83 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 3,159,676k (± 0.01%) 3,159,447k (± 0.02%) ~ 3,158,616k 3,159,963k p=0.471 n=6
Parse Time 8.49s (± 0.43%) 8.36s (± 0.84%) -0.12s (- 1.45%) 8.28s 8.48s p=0.013 n=6
Bind Time 2.63s (± 0.91%) 2.68s (± 1.12%) +0.06s (+ 2.09%) 2.66s 2.74s p=0.016 n=6
Check Time 53.39s (± 0.28%) 53.25s (± 0.22%) ~ 53.13s 53.42s p=0.229 n=6
Emit Time 4.36s (± 1.98%) 4.35s (± 1.68%) ~ 4.26s 4.44s p=1.000 n=6
Total Time 68.87s (± 0.27%) 68.67s (± 0.25%) ~ 68.42s 68.84s p=0.128 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,523 262,356 -167 (- 0.06%) ~ ~ p=0.001 n=6
Types 104,049 103,960 -89 (- 0.09%) ~ ~ p=0.001 n=6
Memory used 440,708k (± 0.02%) 440,594k (± 0.02%) ~ 440,441k 440,687k p=0.065 n=6
Parse Time 3.50s (± 1.54%) 3.52s (± 0.89%) ~ 3.48s 3.56s p=0.686 n=6
Bind Time 1.32s (± 1.73%) 1.32s (± 1.04%) ~ 1.31s 1.35s p=0.512 n=6
Check Time 19.04s (± 0.44%) 19.08s (± 0.44%) ~ 18.95s 19.17s p=0.470 n=6
Emit Time 1.53s (± 0.96%) 1.53s (± 0.80%) ~ 1.51s 1.54s p=0.737 n=6
Total Time 25.39s (± 0.42%) 25.45s (± 0.37%) ~ 25.30s 25.59s p=0.199 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,386 225,386 ~ ~ ~ p=1.000 n=6
Types 94,304 94,304 ~ ~ ~ p=1.000 n=6
Memory used 370,112k (± 0.04%) 370,191k (± 0.07%) ~ 370,009k 370,555k p=0.689 n=6
Parse Time 2.83s (± 1.39%) 2.84s (± 0.81%) ~ 2.81s 2.88s p=0.809 n=6
Bind Time 1.61s (± 0.85%) 1.61s (± 1.69%) ~ 1.58s 1.66s p=0.806 n=6
Check Time 16.48s (± 0.35%) 16.58s (± 0.26%) +0.10s (+ 0.62%) 16.52s 16.63s p=0.016 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 20.92s (± 0.29%) 21.04s (± 0.29%) +0.11s (+ 0.55%) 20.96s 21.13s p=0.016 n=6
vscode - node (v18.15.0, x64)
Errors 11 15 🔻+4 (+36.36%) ~ ~ p=0.001 n=6
Symbols 4,031,459 4,031,459 ~ ~ ~ p=1.000 n=6
Types 1,267,387 1,267,387 ~ ~ ~ p=1.000 n=6
Memory used 3,813,916k (± 0.00%) 3,813,987k (± 0.00%) ~ 3,813,850k 3,814,175k p=0.378 n=6
Parse Time 15.41s (± 0.37%) 15.48s (± 0.34%) ~ 15.42s 15.55s p=0.065 n=6
Bind Time 5.04s (± 0.53%) 5.20s (± 2.12%) +0.16s (+ 3.21%) 5.11s 5.42s p=0.005 n=6
Check Time 105.84s (± 3.27%) 109.19s (± 5.07%) ~ 102.78s 116.78s p=0.298 n=6
Emit Time 43.93s (±20.94%) 39.82s (±17.50%) ~ 31.45s 52.77s p=0.298 n=6
Total Time 170.22s (± 4.70%) 169.69s (± 6.16%) ~ 162.23s 190.22s p=0.575 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 379,718 379,718 ~ ~ ~ p=1.000 n=6
Types 166,559 166,559 ~ ~ ~ p=1.000 n=6
Memory used 539,259k (± 0.02%) 539,273k (± 0.02%) ~ 539,050k 539,416k p=0.936 n=6
Parse Time 4.58s (± 0.99%) 4.59s (± 0.46%) ~ 4.57s 4.62s p=0.747 n=6
Bind Time 1.98s (± 1.71%) 2.01s (± 1.60%) ~ 1.96s 2.04s p=0.256 n=6
Check Time 23.09s (± 1.77%) 22.98s (± 1.13%) ~ 22.76s 23.50s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.65s (± 1.28%) 29.58s (± 0.83%) ~ 29.39s 30.06s p=0.748 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 690,485 690,485 ~ ~ ~ p=1.000 n=6
Types 208,757 208,757 ~ ~ ~ p=1.000 n=6
Memory used 586,553k (± 0.03%) 586,709k (± 0.03%) +155k (+ 0.03%) 586,442k 586,879k p=0.045 n=6
Parse Time 4.17s (± 0.74%) 4.19s (± 0.69%) ~ 4.15s 4.23s p=0.146 n=6
Bind Time 1.34s (± 1.10%) 1.37s (± 0.65%) +0.03s (+ 2.11%) 1.36s 1.38s p=0.007 n=6
Check Time 20.50s (± 1.84%) 20.43s (± 1.56%) ~ 20.23s 21.08s p=0.687 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.01s (± 1.47%) 26.00s (± 1.25%) ~ 25.79s 26.66s p=0.378 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62751/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

12 of 64 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

build/checker/tsconfig.electron-utility.json

build/checker/tsconfig.electron-main.json

TanStack/query

76 of 116 projects failed to build with the old tsc and were ignored

packages/react-query-persist-client/tsconfig.legacy.json

packages/react-query-persist-client/tsconfig.json

packages/react-query-next-experimental/tsconfig.legacy.json

packages/react-query-next-experimental/tsconfig.json

packages/react-query-devtools/tsconfig.legacy.json

packages/react-query-devtools/tsconfig.json

packages/react-query/tsconfig.prod.json

@jakebailey
Copy link
Member Author

jakebailey commented Nov 13, 2025

@typescript-bot test it
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/166527/artifacts?artifactName=tgz&fileId=D0D2533EEEF95114880D0701A6467486A75943488D2EA21B757B54E854516ECE02&fileName=/typescript-6.0.0-insiders.20251113.tgz"
    }
}

and then running npm install.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/62751/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Git clone failed"

Otherwise...

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 193,938k (± 0.96%) 194,467k (± 1.00%) ~ 192,610k 196,283k p=1.000 n=6
Parse Time 1.30s (± 0.69%) 1.30s (± 0.69%) ~ 1.29s 1.31s p=1.000 n=6
Bind Time 0.72s (± 0.57%) 0.72s ~ ~ ~ p=0.405 n=6
Check Time 9.89s (± 0.39%) 9.93s (± 0.23%) +0.04s (+ 0.37%) 9.90s 9.96s p=0.043 n=6
Emit Time 2.73s (± 0.79%) 2.76s (± 0.75%) ~ 2.74s 2.79s p=0.050 n=6
Total Time 14.64s (± 0.12%) 14.70s (± 0.12%) +0.06s (+ 0.42%) 14.68s 14.72s p=0.005 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 956,047 956,047 ~ ~ ~ p=1.000 n=6
Types 415,881 415,881 ~ ~ ~ p=1.000 n=6
Memory used 1,255,044k (± 0.00%) 1,255,026k (± 0.01%) ~ 1,254,948k 1,255,105k p=0.575 n=6
Parse Time 6.53s (± 0.89%) 6.55s (± 0.64%) ~ 6.50s 6.60s p=0.288 n=6
Bind Time 1.88s (± 0.27%) 1.88s (± 0.64%) ~ 1.86s 1.89s p=0.533 n=6
Check Time 32.21s (± 0.35%) 32.39s (± 0.25%) +0.18s (+ 0.55%) 32.28s 32.52s p=0.016 n=6
Emit Time 14.89s (± 0.23%) 14.92s (± 0.77%) ~ 14.81s 15.13s p=0.688 n=6
Total Time 55.52s (± 0.31%) 55.74s (± 0.21%) +0.22s (+ 0.39%) 55.57s 55.88s p=0.030 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,666,324 2,666,324 ~ ~ ~ p=1.000 n=6
Types 922,137 922,137 ~ ~ ~ p=1.000 n=6
Memory used 2,976,951k (± 0.00%) 2,977,043k (± 0.00%) ~ 2,976,971k 2,977,132k p=0.066 n=6
Parse Time 8.41s (± 0.33%) 8.42s (± 0.24%) ~ 8.38s 8.43s p=0.454 n=6
Bind Time 2.18s (± 0.37%) 2.17s (± 0.35%) -0.01s (- 0.69%) 2.16s 2.18s p=0.020 n=6
Check Time 91.98s (± 0.46%) 92.01s (± 0.72%) ~ 91.22s 92.99s p=1.000 n=6
Emit Time 0.31s (± 1.68%) 0.31s (± 1.68%) ~ 0.30s 0.31s p=1.000 n=6
Total Time 102.88s (± 0.41%) 102.90s (± 0.64%) ~ 102.10s 103.89s p=1.000 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,212 -66 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,803 -81 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 2,486,365k (± 7.53%) 2,365,390k (± 0.02%) ~ 2,364,822k 2,366,174k p=0.471 n=6
Parse Time 5.17s (± 0.71%) 5.14s (± 0.79%) ~ 5.07s 5.18s p=0.374 n=6
Bind Time 1.78s (± 0.85%) 1.80s (± 1.13%) ~ 1.78s 1.82s p=0.055 n=6
Check Time 35.08s (± 0.65%) 35.39s (± 0.26%) +0.31s (+ 0.90%) 35.21s 35.46s p=0.013 n=6
Emit Time 3.00s (± 1.42%) 3.01s (± 1.26%) ~ 2.98s 3.08s p=0.810 n=6
Total Time 45.04s (± 0.47%) 45.34s (± 0.12%) +0.30s (+ 0.67%) 45.27s 45.43s p=0.010 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,212 -66 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,803 -81 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 3,159,196k (± 0.02%) 3,159,356k (± 0.03%) ~ 3,158,364k 3,160,879k p=0.810 n=6
Parse Time 8.42s (± 1.00%) 8.35s (± 0.73%) ~ 8.24s 8.42s p=0.298 n=6
Bind Time 2.65s (± 1.25%) 2.63s (± 1.19%) ~ 2.61s 2.69s p=0.421 n=6
Check Time 53.30s (± 0.32%) 53.41s (± 0.20%) ~ 53.32s 53.62s p=0.093 n=6
Emit Time 4.37s (± 1.30%) 4.37s (± 2.69%) ~ 4.16s 4.51s p=0.810 n=6
Total Time 68.74s (± 0.19%) 68.77s (± 0.15%) ~ 68.64s 68.87s p=0.575 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,523 262,369 -154 (- 0.06%) ~ ~ p=0.001 n=6
Types 104,049 103,962 -87 (- 0.08%) ~ ~ p=0.001 n=6
Memory used 440,762k (± 0.00%) 440,590k (± 0.01%) -172k (- 0.04%) 440,527k 440,701k p=0.005 n=6
Parse Time 3.50s (± 0.88%) 3.50s (± 1.29%) ~ 3.42s 3.54s p=1.000 n=6
Bind Time 1.32s (± 0.88%) 1.32s (± 1.24%) ~ 1.29s 1.33s p=0.739 n=6
Check Time 19.06s (± 0.33%) 19.21s (± 0.18%) +0.15s (+ 0.78%) 19.17s 19.27s p=0.005 n=6
Emit Time 1.53s (± 0.53%) 1.51s (± 0.84%) -0.02s (- 1.52%) 1.49s 1.52s p=0.008 n=6
Total Time 25.42s (± 0.27%) 25.53s (± 0.30%) +0.11s (+ 0.45%) 25.41s 25.64s p=0.036 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,386 225,386 ~ ~ ~ p=1.000 n=6
Types 94,304 94,304 ~ ~ ~ p=1.000 n=6
Memory used 370,124k (± 0.05%) 370,128k (± 0.07%) ~ 369,969k 370,621k p=1.000 n=6
Parse Time 2.84s (± 0.96%) 2.83s (± 1.23%) ~ 2.77s 2.87s p=0.870 n=6
Bind Time 1.60s (± 0.94%) 1.61s (± 0.47%) ~ 1.60s 1.62s p=0.054 n=6
Check Time 16.53s (± 0.38%) 16.63s (± 0.30%) +0.10s (+ 0.62%) 16.56s 16.71s p=0.020 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 20.96s (± 0.37%) 21.07s (± 0.34%) +0.11s (+ 0.52%) 20.94s 21.15s p=0.031 n=6
vscode - node (v18.15.0, x64)
Errors 11 11 ~ ~ ~ p=1.000 n=6
Symbols 4,032,941 4,032,941 ~ ~ ~ p=1.000 n=6
Types 1,267,953 1,267,953 ~ ~ ~ p=1.000 n=6
Memory used 3,815,624k (± 0.00%) 3,815,594k (± 0.00%) ~ 3,815,445k 3,815,739k p=0.689 n=6
Parse Time 15.47s (± 0.67%) 15.53s (± 0.64%) ~ 15.46s 15.72s p=0.087 n=6
Bind Time 5.03s (± 0.79%) 5.05s (± 0.62%) ~ 5.02s 5.11s p=0.189 n=6
Check Time 107.36s (± 5.09%) 109.39s (± 5.60%) ~ 102.79s 116.27s p=0.471 n=6
Emit Time 40.16s (±18.19%) 43.12s (±33.53%) ~ 31.73s 62.60s p=0.810 n=6
Total Time 168.02s (± 3.23%) 173.09s (± 6.30%) ~ 162.85s 189.63s p=0.471 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 379,718 379,718 ~ ~ ~ p=1.000 n=6
Types 166,559 166,559 ~ ~ ~ p=1.000 n=6
Memory used 539,366k (± 0.02%) 539,253k (± 0.01%) ~ 539,139k 539,331k p=0.128 n=6
Parse Time 4.63s (± 0.88%) 4.59s (± 0.66%) ~ 4.57s 4.65s p=0.090 n=6
Bind Time 1.97s (± 1.39%) 1.98s (± 1.71%) ~ 1.94s 2.02s p=0.416 n=6
Check Time 22.74s (± 0.31%) 22.79s (± 0.49%) ~ 22.65s 22.92s p=0.423 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.35s (± 0.20%) 29.36s (± 0.33%) ~ 29.24s 29.47s p=0.810 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 690,485 690,485 ~ ~ ~ p=1.000 n=6
Types 208,757 208,757 ~ ~ ~ p=1.000 n=6
Memory used 586,612k (± 0.03%) 586,588k (± 0.03%) ~ 586,373k 586,841k p=0.689 n=6
Parse Time 4.17s (± 0.84%) 4.18s (± 0.98%) ~ 4.13s 4.25s p=0.870 n=6
Bind Time 1.35s (± 1.09%) 1.36s (± 1.36%) ~ 1.33s 1.38s p=0.167 n=6
Check Time 20.66s (± 1.90%) 20.75s (± 2.08%) ~ 20.30s 21.19s p=0.810 n=6
Emit Time 0.00s (±154.76%) 0.00s (±244.70%) ~ 0.00s 0.01s p=0.595 n=6
Total Time 26.18s (± 1.51%) 26.30s (± 1.56%) ~ 25.82s 26.71s p=0.810 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62751/merge:

Everything looks good!

@jakebailey
Copy link
Member Author

jakebailey commented Nov 13, 2025

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 196,290k (± 0.05%) 196,133k (± 0.08%) ~ 195,907k 196,338k p=0.066 n=6
Parse Time 1.61s (± 0.85%) 1.60s (± 2.05%) ~ 1.54s 1.63s p=0.933 n=6
Bind Time 0.88s (± 1.57%) 0.88s (± 1.18%) ~ 0.87s 0.90s p=0.249 n=6
Check Time 12.04s (± 0.42%) 12.02s (± 0.53%) ~ 11.96s 12.11s p=0.573 n=6
Emit Time 3.35s (± 4.14%) 3.49s (± 4.85%) ~ 3.23s 3.67s p=0.261 n=6
Total Time 17.87s (± 0.95%) 18.00s (± 0.87%) ~ 17.72s 18.18s p=0.297 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 956,047 956,047 ~ ~ ~ p=1.000 n=6
Types 415,881 415,881 ~ ~ ~ p=1.000 n=6
Memory used 1,255,182k (± 0.01%) 1,255,159k (± 0.01%) ~ 1,255,081k 1,255,268k p=0.378 n=6
Parse Time 8.01s (± 0.65%) 7.98s (± 0.82%) ~ 7.91s 8.05s p=0.808 n=6
Bind Time 2.27s (± 0.99%) 2.28s (± 0.80%) ~ 2.26s 2.31s p=1.000 n=6
Check Time 38.71s (± 0.18%) 38.70s (± 0.39%) ~ 38.56s 38.95s p=0.573 n=6
Emit Time 17.96s (± 0.22%) 17.91s (± 0.55%) ~ 17.75s 18.00s p=0.574 n=6
Total Time 66.95s (± 0.18%) 66.86s (± 0.23%) ~ 66.69s 67.13s p=0.298 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,666,324 2,666,324 ~ ~ ~ p=1.000 n=6
Types 922,137 922,137 ~ ~ ~ p=1.000 n=6
Memory used 2,977,269k (± 0.01%) 2,977,348k (± 0.01%) ~ 2,977,127k 2,977,549k p=0.471 n=6
Parse Time 12.56s (± 0.52%) 12.52s (± 0.87%) ~ 12.35s 12.66s p=0.574 n=6
Bind Time 3.29s (± 1.31%) 3.42s (±10.69%) ~ 3.25s 4.17s p=0.872 n=6
Check Time 135.42s (± 0.95%) 134.50s (± 0.26%) ~ 134.09s 134.84s p=0.128 n=6
Emit Time 0.45s (± 2.17%) 0.46s (± 3.19%) ~ 0.44s 0.48s p=0.216 n=6
Total Time 151.72s (± 0.82%) 150.91s (± 0.38%) ~ 150.31s 151.83s p=0.173 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,141 -137 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,801 -83 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 2,999,859k (± 7.83%) 2,974,724k (± 9.98%) ~ 2,368,246k 3,096,758k p=0.936 n=6
Parse Time 6.59s (± 1.71%) 6.55s (± 2.00%) ~ 6.31s 6.71s p=0.378 n=6
Bind Time 2.15s (± 1.34%) 2.12s (± 0.63%) -0.03s (- 1.32%) 2.10s 2.14s p=0.033 n=6
Check Time 42.70s (± 0.93%) 42.91s (± 0.23%) ~ 42.76s 43.04s p=0.229 n=6
Emit Time 3.46s (± 2.34%) 3.45s (± 1.85%) ~ 3.39s 3.54s p=0.936 n=6
Total Time 54.90s (± 0.86%) 55.02s (± 0.33%) ~ 54.73s 55.25s p=0.810 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,141 -137 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,801 -83 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 3,160,302k (± 0.02%) 3,159,929k (± 0.03%) ~ 3,158,535k 3,161,252k p=0.689 n=6
Parse Time 6.88s (± 0.65%) 6.74s (± 0.83%) -0.14s (- 2.11%) 6.65s 6.81s p=0.006 n=6
Bind Time 2.16s (± 1.09%) 2.13s (± 0.89%) ~ 2.11s 2.15s p=0.128 n=6
Check Time 42.99s (± 0.32%) 43.06s (± 0.35%) ~ 42.79s 43.20s p=0.470 n=6
Emit Time 3.47s (± 1.06%) 3.46s (± 3.57%) ~ 3.31s 3.61s p=1.000 n=6
Total Time 55.51s (± 0.22%) 55.39s (± 0.41%) ~ 55.01s 55.62s p=0.471 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,523 262,364 -159 (- 0.06%) ~ ~ p=0.001 n=6
Types 104,049 103,960 -89 (- 0.09%) ~ ~ p=0.001 n=6
Memory used 440,725k (± 0.00%) 440,628k (± 0.02%) -97k (- 0.02%) 440,540k 440,728k p=0.020 n=6
Parse Time 3.52s (± 1.10%) 3.50s (± 0.90%) ~ 3.45s 3.54s p=0.257 n=6
Bind Time 1.32s (± 0.74%) 1.33s (± 1.43%) ~ 1.31s 1.36s p=0.510 n=6
Check Time 19.11s (± 0.30%) 19.27s (± 0.30%) +0.17s (+ 0.87%) 19.20s 19.32s p=0.005 n=6
Emit Time 1.53s (± 0.79%) 1.53s (± 1.14%) ~ 1.52s 1.56s p=0.617 n=6
Total Time 25.47s (± 0.29%) 25.63s (± 0.35%) +0.16s (+ 0.62%) 25.49s 25.75s p=0.012 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,386 225,386 ~ ~ ~ p=1.000 n=6
Types 94,304 94,304 ~ ~ ~ p=1.000 n=6
Memory used 370,078k (± 0.02%) 370,157k (± 0.03%) ~ 370,061k 370,319k p=0.066 n=6
Parse Time 2.85s (± 0.95%) 2.84s (± 1.31%) ~ 2.78s 2.89s p=1.000 n=6
Bind Time 1.60s (± 1.46%) 1.60s (± 1.29%) ~ 1.57s 1.63s p=0.934 n=6
Check Time 16.52s (± 0.44%) 16.55s (± 0.61%) ~ 16.43s 16.68s p=0.520 n=6
Emit Time 0.00s 0.00s (±244.70%) ~ 0.00s 0.01s p=0.405 n=6
Total Time 20.97s (± 0.28%) 21.00s (± 0.37%) ~ 20.90s 21.10s p=0.573 n=6
vscode - node (v18.15.0, x64)
Errors 11 11 ~ ~ ~ p=1.000 n=6
Symbols 4,033,115 4,033,115 ~ ~ ~ p=1.000 n=6
Types 1,267,957 1,267,957 ~ ~ ~ p=1.000 n=6
Memory used 3,815,809k (± 0.00%) 3,815,811k (± 0.01%) ~ 3,815,472k 3,816,273k p=0.689 n=6
Parse Time 15.65s (± 2.45%) 15.51s (± 0.78%) ~ 15.34s 15.66s p=0.936 n=6
Bind Time 5.10s (± 3.39%) 5.11s (± 2.17%) ~ 5.04s 5.33s p=0.332 n=6
Check Time 104.65s (± 3.47%) 106.78s (± 4.29%) ~ 103.02s 112.60s p=0.378 n=6
Emit Time 41.84s (±25.88%) 42.21s (±26.48%) ~ 31.70s 60.69s p=0.689 n=6
Total Time 167.24s (± 5.75%) 169.61s (± 5.47%) ~ 161.95s 184.87s p=0.575 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 379,718 379,718 ~ ~ ~ p=1.000 n=6
Types 166,559 166,559 ~ ~ ~ p=1.000 n=6
Memory used 539,051k (± 0.05%) 539,011k (± 0.02%) ~ 538,782k 539,151k p=0.298 n=6
Parse Time 3.82s (± 0.68%) 3.82s (± 0.61%) ~ 3.79s 3.85s p=0.567 n=6
Bind Time 1.60s (± 1.10%) 1.60s (± 0.56%) ~ 1.59s 1.61s p=1.000 n=6
Check Time 19.18s (± 1.47%) 19.09s (± 1.22%) ~ 18.97s 19.57s p=0.470 n=6
Emit Time 0.01s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 24.61s (± 1.19%) 24.51s (± 1.02%) ~ 24.36s 25.02s p=0.257 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 690,485 690,485 ~ ~ ~ p=1.000 n=6
Types 208,757 208,757 ~ ~ ~ p=1.000 n=6
Memory used 586,557k (± 0.03%) 586,559k (± 0.03%) ~ 586,450k 586,792k p=1.000 n=6
Parse Time 4.20s (± 0.94%) 4.20s (± 0.91%) ~ 4.17s 4.26s p=0.870 n=6
Bind Time 1.34s (± 1.02%) 1.36s (± 0.76%) ~ 1.34s 1.37s p=0.156 n=6
Check Time 20.89s (± 1.69%) 20.89s (± 1.71%) ~ 20.43s 21.18s p=0.630 n=6
Emit Time 0.00s (±154.76%) 0.00s (±244.70%) ~ 0.00s 0.01s p=0.595 n=6
Total Time 26.45s (± 1.39%) 26.46s (± 1.39%) ~ 25.96s 26.77s p=0.748 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey
Copy link
Member Author

jakebailey commented Nov 13, 2025

@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 13, 2025

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 1 1 ~ ~ ~ p=1.000 n=6
Symbols 62,370 62,370 ~ ~ ~ p=1.000 n=6
Types 50,386 50,386 ~ ~ ~ p=1.000 n=6
Memory used 194,599k (± 0.93%) 193,831k (± 0.95%) ~ 192,610k 196,221k p=0.066 n=6
Parse Time 1.30s (± 0.31%) 1.30s (± 0.64%) ~ 1.29s 1.31s p=0.285 n=6
Bind Time 0.72s (± 0.57%) 0.72s ~ ~ ~ p=0.405 n=6
Check Time 9.88s (± 0.25%) 9.91s (± 0.42%) ~ 9.87s 9.98s p=0.257 n=6
Emit Time 2.73s (± 0.68%) 2.74s (± 0.36%) ~ 2.73s 2.76s p=0.209 n=6
Total Time 14.64s (± 0.13%) 14.68s (± 0.35%) ~ 14.63s 14.77s p=0.195 n=6
angular-1 - node (v18.15.0, x64)
Errors 2 2 ~ ~ ~ p=1.000 n=6
Symbols 956,047 956,047 ~ ~ ~ p=1.000 n=6
Types 415,881 415,881 ~ ~ ~ p=1.000 n=6
Memory used 1,255,003k (± 0.00%) 1,254,985k (± 0.00%) ~ 1,254,913k 1,255,048k p=0.575 n=6
Parse Time 6.56s (± 0.59%) 6.54s (± 0.69%) ~ 6.47s 6.59s p=0.569 n=6
Bind Time 1.88s (± 0.22%) 1.88s (± 0.58%) ~ 1.86s 1.89s p=1.000 n=6
Check Time 32.35s (± 0.29%) 32.39s (± 0.13%) ~ 32.34s 32.46s p=0.332 n=6
Emit Time 14.93s (± 0.10%) 14.88s (± 0.26%) -0.05s (- 0.33%) 14.81s 14.93s p=0.023 n=6
Total Time 55.71s (± 0.18%) 55.70s (± 0.10%) ~ 55.63s 55.79s p=1.000 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,666,324 2,666,324 ~ ~ ~ p=1.000 n=6
Types 922,137 922,137 ~ ~ ~ p=1.000 n=6
Memory used 2,976,975k (± 0.00%) 2,977,016k (± 0.00%) ~ 2,976,875k 2,977,123k p=0.630 n=6
Parse Time 8.40s (± 0.33%) 8.42s (± 0.23%) ~ 8.40s 8.45s p=0.145 n=6
Bind Time 2.17s (± 0.58%) 2.17s (± 0.19%) ~ 2.16s 2.17s p=0.546 n=6
Check Time 91.79s (± 0.37%) 92.00s (± 0.45%) ~ 91.40s 92.65s p=0.575 n=6
Emit Time 0.30s (± 1.35%) 0.30s (± 1.70%) ~ 0.30s 0.31s p=0.595 n=6
Total Time 102.66s (± 0.32%) 102.89s (± 0.41%) ~ 102.30s 103.56s p=0.521 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,141 -137 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,801 -83 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 2,365,182k (± 0.02%) 2,608,020k (±14.37%) 🔻+242,837k (+10.27%) 2,365,463k 3,093,039k p=0.013 n=6
Parse Time 5.16s (± 1.38%) 5.17s (± 1.75%) ~ 5.11s 5.33s p=0.810 n=6
Bind Time 1.78s (± 0.85%) 1.79s (± 1.55%) ~ 1.74s 1.82s p=0.223 n=6
Check Time 35.26s (± 0.27%) 35.56s (± 0.74%) ~ 35.25s 35.93s p=0.066 n=6
Emit Time 3.00s (± 0.40%) 3.00s (± 1.00%) ~ 2.96s 3.05s p=0.808 n=6
Total Time 45.22s (± 0.24%) 45.54s (± 0.73%) ~ 45.15s 46.03s p=0.093 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,237,278 1,237,141 -137 (- 0.01%) ~ ~ p=0.001 n=6
Types 259,884 259,801 -83 (- 0.03%) ~ ~ p=0.001 n=6
Memory used 3,159,188k (± 0.02%) 3,039,139k (± 9.71%) ~ 2,436,130k 3,160,747k p=0.810 n=6
Parse Time 6.83s (± 0.39%) 6.70s (± 1.64%) -0.14s (- 2.00%) 6.51s 6.84s p=0.020 n=6
Bind Time 2.16s (± 1.32%) 2.16s (± 1.01%) ~ 2.14s 2.20s p=1.000 n=6
Check Time 43.01s (± 0.32%) 43.04s (± 0.46%) ~ 42.68s 43.22s p=0.574 n=6
Emit Time 3.56s (± 2.09%) 3.52s (± 3.05%) ~ 3.34s 3.64s p=0.572 n=6
Total Time 55.57s (± 0.32%) 55.43s (± 0.61%) ~ 54.88s 55.79s p=0.378 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,523 262,364 -159 (- 0.06%) ~ ~ p=0.001 n=6
Types 104,049 103,960 -89 (- 0.09%) ~ ~ p=0.001 n=6
Memory used 440,742k (± 0.01%) 440,643k (± 0.02%) -99k (- 0.02%) 440,571k 440,778k p=0.031 n=6
Parse Time 4.36s (± 1.03%) 4.36s (± 0.81%) ~ 4.30s 4.40s p=0.747 n=6
Bind Time 1.64s (± 0.60%) 1.64s (± 0.50%) ~ 1.63s 1.65s p=0.862 n=6
Check Time 23.67s (± 0.56%) 23.92s (± 0.55%) +0.25s (+ 1.06%) 23.71s 24.10s p=0.020 n=6
Emit Time 1.91s (± 0.79%) 1.90s (± 1.03%) ~ 1.88s 1.93s p=0.684 n=6
Total Time 31.58s (± 0.51%) 31.83s (± 0.49%) +0.26s (+ 0.81%) 31.57s 32.02s p=0.045 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 72 72 ~ ~ ~ p=1.000 n=6
Symbols 225,386 225,386 ~ ~ ~ p=1.000 n=6
Types 94,304 94,304 ~ ~ ~ p=1.000 n=6
Memory used 370,052k (± 0.02%) 370,240k (± 0.08%) ~ 369,961k 370,615k p=0.378 n=6
Parse Time 2.82s (± 0.81%) 2.82s (± 0.86%) ~ 2.79s 2.85s p=0.869 n=6
Bind Time 1.59s (± 1.34%) 1.60s (± 0.97%) ~ 1.58s 1.62s p=0.371 n=6
Check Time 16.50s (± 0.20%) 16.62s (± 0.30%) +0.12s (+ 0.73%) 16.55s 16.68s p=0.006 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 20.92s (± 0.27%) 21.05s (± 0.23%) +0.13s (+ 0.64%) 20.99s 21.13s p=0.005 n=6
vscode - node (v18.15.0, x64)
Errors 11 11 ~ ~ ~ p=1.000 n=6
Symbols 4,033,115 4,033,115 ~ ~ ~ p=1.000 n=6
Types 1,267,957 1,267,957 ~ ~ ~ p=1.000 n=6
Memory used 3,815,875k (± 0.00%) 3,815,846k (± 0.00%) ~ 3,815,739k 3,815,990k p=0.575 n=6
Parse Time 15.47s (± 0.20%) 15.49s (± 0.32%) ~ 15.42s 15.56s p=0.625 n=6
Bind Time 5.06s (± 0.79%) 5.07s (± 0.76%) ~ 5.02s 5.12s p=0.686 n=6
Check Time 107.54s (± 3.78%) 109.40s (± 3.43%) ~ 103.20s 112.75s p=0.471 n=6
Emit Time 37.22s (± 7.62%) 40.19s (±15.45%) ~ 32.00s 50.50s p=0.689 n=6
Total Time 165.29s (± 1.43%) 170.15s (± 4.54%) ~ 162.29s 183.84s p=0.378 n=6
webpack - node (v18.15.0, x64)
Errors 40 40 ~ ~ ~ p=1.000 n=6
Symbols 379,718 379,718 ~ ~ ~ p=1.000 n=6
Types 166,559 166,559 ~ ~ ~ p=1.000 n=6
Memory used 539,378k (± 0.02%) 539,230k (± 0.03%) ~ 538,986k 539,442k p=0.173 n=6
Parse Time 4.59s (± 1.09%) 4.62s (± 0.27%) ~ 4.61s 4.64s p=0.196 n=6
Bind Time 1.97s (± 2.09%) 1.97s (± 1.45%) ~ 1.93s 2.01s p=1.000 n=6
Check Time 22.89s (± 0.52%) 23.04s (± 1.52%) ~ 22.76s 23.52s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 29.45s (± 0.61%) 29.63s (± 1.20%) ~ 29.33s 30.11s p=0.810 n=6
xstate-main - node (v18.15.0, x64)
Errors 30 30 ~ ~ ~ p=1.000 n=6
Symbols 690,485 690,485 ~ ~ ~ p=1.000 n=6
Types 208,757 208,757 ~ ~ ~ p=1.000 n=6
Memory used 586,620k (± 0.03%) 586,663k (± 0.02%) ~ 586,431k 586,746k p=0.810 n=6
Parse Time 4.18s (± 0.72%) 4.16s (± 0.78%) ~ 4.12s 4.20s p=0.295 n=6
Bind Time 1.34s (± 0.90%) 1.35s (± 1.30%) ~ 1.33s 1.38s p=1.000 n=6
Check Time 20.53s (± 1.85%) 20.52s (± 1.42%) ~ 20.30s 21.10s p=0.335 n=6
Emit Time 0.00s (±244.70%) 0.00s (±154.76%) ~ 0.00s 0.01s p=0.595 n=6
Total Time 26.06s (± 1.50%) 26.03s (± 1.19%) ~ 25.84s 26.65s p=0.298 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Nov 14, 2025
@jakebailey jakebailey merged commit 09e31cf into microsoft:main Nov 14, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Nov 14, 2025
@jakebailey jakebailey deleted the port-tsgo-2067 branch November 14, 2025 01:50
@jakebailey
Copy link
Member Author

jakebailey commented Nov 14, 2025

@typescript-bot cherry-pick this to tsgo-port

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 14, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to tsgo-port ✅ Started ✅ Results

typescript-bot pushed a commit that referenced this pull request Nov 14, 2025
@jakebailey @typescript-bot
Move unreachable checks to checker (#62751)
45f30b3
@typescript-bot typescript-bot mentioned this pull request Nov 14, 2025
Merged
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 14, 2025

Hey, @jakebailey! I've created #62760 for you. This involved updating baselines; please check the diff.

jakebailey added a commit that referenced this pull request Nov 14, 2025
@typescript-bot @jakebailey
🤖 Pick PR #62751 (Move unreachable checks to checker) into tsgo-port (#…
54d464b 
…62760)

Co-authored-by: Jake Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@sandersn sandersn

@jakebailey jakebailey

Labels

Author: Team For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only first unreachable statement flagged in 'case'

4 participants

@jakebailey @typescript-bot @DanielRosenwasser @sandersn