Fix completions for generic overloads with mixed function/object parameters #62763
+131
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62693
Problem
When a generic function has overloads with mixed parameter types (function vs object literal), TypeScript shows incorrect completions for object literals. For example:
The editor shows function properties (bind, call, apply) instead of the expected object property "make".
Root Cause
During completion, generic type inference is blocked (type parameters are unknown). When
chooseOverloadevaluates candidates, it:Tduring completion contextThe issue occurs because overload selection doesn't account for the syntactic context (completing an object literal) when generic inference is unavailable.
Solution
The fix tracks which argument position is being completed and uses this information during overload resolution to prefer object-type overloads when completing object literals.
Changes
types.ts (line 6311):
Added
completionArgumentIndexto NodeLinks to track which argument is being completed.checker.ts (lines 32072-32076):
Store the argument index when inference is blocked during completion:
checker.ts (lines 36728-36832):
Enhanced
chooseOverloadto:This allows the type checker to select the correct overload based on syntactic context rather than relying solely on type inference.
Why This Works
The fix is surgical and only affects generic overload resolution during completion:
The approach respects TypeScript's existing completion infrastructure while providing better overload selection for this specific edge case.
Testing
Added comprehensive test coverage in
completionForGenericOverloadObjectLiteral.ts:All tests verify that object properties appear in completions and function properties (bind, call, apply) are correctly excluded.
Test results: 99,000 passing, 0 regressions