Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera still being used after closing camera preview page #1638

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcelwgn
Copy link
Contributor

Description

When leaving the camera capture page, the camera now no longer is in use.

Motivation and Context

Closes #1610

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl
Copy link
Collaborator

karkarl commented Nov 13, 2024

/azp run

1 similar comment
@karkarl
Copy link
Collaborator

karkarl commented Nov 13, 2024

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Nov 14, 2024

Can you try rebasing from main and see if the latest changes help with the test failures?

@marcelwgn
Copy link
Contributor Author

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Nov 14, 2024

The tests are failing after the Axe scan on the camera preview page. This may be related to your changes :/

{38FE4255-3233-4479-A874-93E62863FFD5}

@marcelwgn
Copy link
Contributor Author

/azp run

1 similar comment
@marcelwgn
Copy link
Contributor Author

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera Element / Camera Preview Make Reamin Active
2 participants