Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix camera still being used after closing camera preview page #1638

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix camera still being used after closing camera preview page #1638

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ff9938
Fix camera still being used after closing camera preview page
Oct 25, 2024
0f556e6
Merge branch 'microsoft:main' into dev/camera-issue
marcelwgn Nov 14, 2024
38ba345
Only dispose mediacapture when it is not null
Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions WinUIGallery/ControlPages/CaptureElementPreviewPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
using Windows.Storage.Streams;
using System.ComponentModel;
using WinUIGallery.Helper;
using System.Threading.Tasks;

namespace WinUIGallery.ControlPages
{
Expand All @@ -38,6 +39,14 @@ public CaptureElementPreviewPage()
captureContainer.Children.Remove(sv);
captureContainer.Children.Add(expandToFillContainer);
expandToFillContainer.Children.Add(sv);

this.Unloaded += this.CaptureElementPreviewPage_Unloaded;
}

private void CaptureElementPreviewPage_Unloaded(object sender, RoutedEventArgs e)
{
// Needs to run as task to unblock UI thread
new Task(mediaCapture.Dispose).Start();
}

private MediaFrameSourceGroup mediaFrameSourceGroup;
Expand Down