Fix SharedMemory redirection queue and add telemetry events #6127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaholme
reviewed
Jan 8, 2026
| DEFINE_COMPLIANT_MEASURES_EVENT(ActivationRegistrationManager, PDT_ProductAndServiceUsage); | ||
| DEFINE_COMPLIANT_MEASURES_EVENT(Restart, PDT_ProductAndServiceUsage); | ||
|
|
||
| DEFINE_COMPLIANT_MEASURES_EVENT_PARAM1(ActivatedEventAdd, PDT_ProductAndServiceUsage, uint32_t, processId); |
There was a problem hiding this comment.
this seems rather noisy to produce at a measures level, do we need this or could it be tracelogging that is captured when the crash dump is collected?
jaholme
reviewed
Jan 8, 2026
dev/AppLifecycle/SharedMemory.h
Outdated
| OpenInternal(size); | ||
|
|
||
| // OpenInternal needs to account for "size" member of DynamicSharedMemory struct. | ||
| OpenInternal(size + sizeof(size_t)); |
There was a problem hiding this comment.
should we just make this adjustment within OpenInternal itself rather than requiring callers to know this? #Resolved
jaholme
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes pointer arithmetic of redirection queue, adds comments and telemetry events.