Skip to content

Update Azure API key env var name and switch to branch-based workflow #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

skytin1004
Copy link
Contributor

@skytin1004 skytin1004 commented Jun 11, 2025

I noticed that the Azure AI Service API key was not properly configured, which caused Co-op Translator to run in markdown-only mode.

To address this, I updated the environment variable from AZURE_SUBSCRIPTION_KEY to the correct AZURE_AI_SERVICE_API_KEY.
Could you please check whether the corresponding GitHub secret (AZURE_AI_SERVICE_API_KEY) is properly configured in this repository?

AZURE_AI_SERVICE_API_KEY: ${{ secrets.AZURE_AI_SERVICE_API_KEY }}
AZURE_AI_SERVICE_ENDPOINT: ${{ secrets.AZURE_AI_SERVICE_ENDPOINT }}
AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }}
AZURE_OPENAI_ENDPOINT: ${{ secrets.AZURE_OPENAI_ENDPOINT }}
AZURE_OPENAI_MODEL_NAME: ${{ secrets.AZURE_OPENAI_MODEL_NAME }}
AZURE_OPENAI_CHAT_DEPLOYMENT_NAME: ${{ secrets.AZURE_OPENAI_CHAT_DEPLOYMENT_NAME }}
AZURE_OPENAI_API_VERSION: ${{ secrets.AZURE_OPENAI_API_VERSION }}
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
OPENAI_ORG_ID: ${{ secrets.OPENAI_ORG_ID }}
OPENAI_CHAT_MODEL_ID: ${{ secrets.OPENAI_CHAT_MODEL_ID }}
OPENAI_BASE_URL: ${{ secrets.OPENAI_BASE_URL }}

In addition, I changed the workflow trigger to a branch-based trigger instead of PR-based.
This avoids CLA license check failures when PRs are created by the Co-op Translator bot.

Copy link
Contributor

👋 Thanks for contributing @skytin1004! We will review the pull request and get back to you soon.

@leestott
Copy link
Contributor

@skytin1004 thanks for spotting this!

@leestott leestott merged commit ae0c7fd into microsoft:main Jun 11, 2025
2 checks passed
@skytin1004 skytin1004 deleted the update-workflow branch June 11, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants