Skip to content

Conversation

@cleemullins
Copy link
Contributor

@cleemullins cleemullins commented Dec 15, 2025

#minor

This pull request primarily adds CodeQL suppression comments and deprecation notes throughout the codebase, in preparation for the planned archiving of several libraries and test packages on December 31, 2025. Additionally, it comments out all tests in JwtTokenExtractorTests and makes a minor fix in an attachment test. These changes are aimed at clarifying the context for static analysis tools and future maintainers, especially regarding deprecated or legacy code.

The most important changes are:

Deprecation and CodeQL Suppression Comments:

  • Added CodeQL suppression comments to various files and methods, clarifying that the flagged patterns are either required by external libraries, legacy design, or only present in test/debug code. Each comment also notes the planned archival date of the relevant package or project. [1] [2] [3] [4] [5] [6] [7] [8]

Test Code Changes:

  • Commented out all code and tests in JwtTokenExtractorTests.cs, with a note that the tests and package are deprecated and scheduled for removal.
  • Minor fix in AttachmentTests.cs to the assertion for byte array equality.

Build Configuration:

  • Suppressed warning NU1510 in Directory.Build.props, which relates to package deprecation, aligning with the overall deprecation and archival plan.

@cleemullins cleemullins self-assigned this Dec 15, 2025
@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label Dec 15, 2025
@tracyboehrer tracyboehrer merged commit 6990913 into main Dec 15, 2025
6 of 7 checks passed
@tracyboehrer tracyboehrer deleted the users/cleemullins/SFIFixesAndSupressions branch December 15, 2025 21:54
Copilot AI pushed a commit to rido-min/botbuilder-dotnet that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants