Skip to content

Add a new page with guidance on how to write UI/e2e tests for a Teams application #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 17, 2024

Conversation

adinastoll
Copy link
Contributor

@adinastoll adinastoll commented Mar 8, 2024

Pull Request Template

What are you trying to address

Contributing with a new guidance based on previous engagement on how to write UI tests for a custom Teams application.

Checklist

  • Changes follow the repo structure and land in the appropriate folder and section
  • No confidential information
  • No duplicated content
  • Labeled appropriately
  • Added 2 reviewers
  • No lint errors
  • No lint check errors related to your changes

Note: You may see link check errors on pages you have not touched. This is normal, and due to either broken links or sites that reject link checker bots. The reviewer will help you get to a green state on these.

Sorry, something went wrong.

@adinastoll adinastoll changed the title Add a new page with guidance on how to write UI tests for a Teams application Add a new page with guidance on how to write UI tests for a custom Teams application Mar 8, 2024
Copy link
Member

@benjguin benjguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me.

A few remarks:

1/ Maybe the step by step instructions are too detailed for the playbook and may generate significant maintenance work of this page over time.
I'm not managing the playbook content, so I'm not sure.

2/ Maybe a chapter or a paragraph in the Overview should summarize the findings. I think of:

  • testing in Web Browser is simpler than on a native app
  • Testing in a local Windows box is more stable than in a CICD that involves a CICD agent plus a VM in VM for the emulator
  • Testing in a Teams app in a native app is hard
    • you are testing an app in Teams App, not the Teams App for which you don't have the APK. Frameworks expoct you to test the app for which you have the APK
    • it requires the installation of the app which is hard to automate because it requires a Google account to access the Play store

Things of that level

adinastoll and others added 8 commits March 13, 2024 16:04
Co-authored-by: Benjamin Guinebertière <benjguin@users.noreply.github.com>
Co-authored-by: Benjamin Guinebertière <benjguin@users.noreply.github.com>
Co-authored-by: Benjamin Guinebertière <benjguin@users.noreply.github.com>
@adinastoll
Copy link
Contributor Author

@benjguin Thank you for the review! :) Based on your suggestion, I added a sub-chapter in Overview to highlight the learnings. Thanks for the suggestion!

I'll keep the step by steps until further feedback from Playbook maintainers, though your point is really valid. I might keep just the aspects which are relevant to Teams (such as choosing a device with Play Store enabled, else Teams can't be installed etc)

Copy link
Member

@TessFerrandez TessFerrandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content... I have added some language suggestions and general formatting

@TessFerrandez TessFerrandez added the testing Testing topic label Mar 15, 2024
@adinastoll adinastoll marked this pull request as ready for review March 15, 2024 14:09
adinastoll and others added 9 commits March 15, 2024 15:10
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
@adinastoll
Copy link
Contributor Author

Great content... I have added some language suggestions and general formatting

Thank you @TessFerrandez for your review! I have addressed the comments. :)

@TessFerrandez
Copy link
Member

@shiranr or @tompaana could one of you review this?

@TessFerrandez TessFerrandez requested a review from tompaana April 3, 2024 11:13
@shiranr
Copy link
Contributor

shiranr commented Apr 12, 2024

Great content! thank you for contributing :)
Left couple of comments.

@adinastoll
Copy link
Contributor Author

Great content! thank you for contributing :) Left couple of comments.

Thank you for reviewing it, @shiranr. I have addressed all your comments! Please have a look.

@adinastoll adinastoll changed the title Add a new page with guidance on how to write UI tests for a custom Teams application Add a new page with guidance on how to write UI/e2e tests for a Teams application Apr 16, 2024
Copy link
Contributor

@shiranr shiranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@shiranr shiranr merged commit 4f23545 into microsoft:main Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants