-
Notifications
You must be signed in to change notification settings - Fork 615
Add a new page with guidance on how to write UI/e2e tests for a Teams application #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new page with guidance on how to write UI/e2e tests for a Teams application #1038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks good to me.
A few remarks:
1/ Maybe the step by step instructions are too detailed for the playbook and may generate significant maintenance work of this page over time.
I'm not managing the playbook content, so I'm not sure.
2/ Maybe a chapter or a paragraph in the Overview should summarize the findings. I think of:
- testing in Web Browser is simpler than on a native app
- Testing in a local Windows box is more stable than in a CICD that involves a CICD agent plus a VM in VM for the emulator
- Testing in a Teams app in a native app is hard
- you are testing an app in Teams App, not the Teams App for which you don't have the APK. Frameworks expoct you to test the app for which you have the APK
- it requires the installation of the app which is hard to automate because it requires a Google account to access the Play store
Things of that level
Co-authored-by: Benjamin Guinebertière <benjguin@users.noreply.github.com>
Co-authored-by: Benjamin Guinebertière <benjguin@users.noreply.github.com>
Co-authored-by: Benjamin Guinebertière <benjguin@users.noreply.github.com>
…nastoll/code-with-engineering-playbook into adnegrau/2050/teams-ui-tests
@benjguin Thank you for the review! :) Based on your suggestion, I added a sub-chapter in Overview to highlight the learnings. Thanks for the suggestion! I'll keep the step by steps until further feedback from Playbook maintainers, though your point is really valid. I might keep just the aspects which are relevant to Teams (such as choosing a device with Play Store enabled, else Teams can't be installed etc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content... I have added some language suggestions and general formatting
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Co-authored-by: Tess Ferrandez <tess_ferrandez@hotmail.com>
Thank you @TessFerrandez for your review! I have addressed the comments. :) |
Great content! thank you for contributing :) |
Co-authored-by: Shiran Rubin <shiranrubin@gmail.com>
Thank you for reviewing it, @shiranr. I have addressed all your comments! Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks
Pull Request Template
What are you trying to address
Contributing with a new guidance based on previous engagement on how to write UI tests for a custom Teams application.
Checklist