feat(rust): allow specifying features to cargo metadata#1009
Open
feat(rust): allow specifying features to cargo metadata#1009
cargo metadata#1009Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
=====================================
Coverage 75.3% 75.3%
=====================================
Files 236 236
Lines 10353 10357 +4
Branches 1025 1026 +1
=====================================
+ Hits 7800 7804 +4
Misses 2269 2269
Partials 284 284 ☔ View full report in Codecov by Sentry. |
Contributor
|
I think it's time to start investing in a file-based configuration approach where we have a top-level service read a file from something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1001
This uses a new environment variable to configure the Rust CLI detector,
CD_RUST_CLI_FEATURES. Open to any other ideas on how to pass this into the detector.