Open
Conversation
nibanks
reviewed
Sep 9, 2024
Contributor
nibanks
left a comment
nibanks
left a comment
There was a problem hiding this comment.
Please add some tests for these new functions.
Comment on lines
+641
to
+642
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
nit: only 1 trailing blank newline
Comment on lines
+639
to
+640
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
nit: only 1 trailing blank newline
| inline | ||
| BOOLEAN | ||
| CxPlatSetThreadNodeAffinity( | ||
| LONG NodeAffinity |
Contributor
There was a problem hiding this comment.
Let's not use Windows style all caps types like LONG.
Suggested change
| LONG NodeAffinity | |
| uint32_t NodeAffinity |
Comment on lines
+630
to
+635
| GROUP_AFFINITY group = {0}; | ||
|
|
||
| group.Mask = CpuAffinity; | ||
| group.Group = (USHORT)GroupNumber; | ||
|
|
||
| KeSetSystemGroupAffinityThread(&group, NULL); |
Contributor
There was a problem hiding this comment.
Suggested change
| GROUP_AFFINITY group = {0}; | |
| group.Mask = CpuAffinity; | |
| group.Group = (USHORT)GroupNumber; | |
| KeSetSystemGroupAffinityThread(&group, NULL); | |
| GROUP_AFFINITY group = { (KAFFINITY)CpuAffinity, GroupNumber, 0 }; | |
| KeSetSystemGroupAffinityThread(&group, NULL); |
Contributor
There was a problem hiding this comment.
And make the similar changes to user mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move from xdp-for-windows to here