-
Notifications
You must be signed in to change notification settings - Fork 21
Improve gather_result, remove filter, fix inf loop in truncation #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+197
−620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheper
reviewed
Jul 24, 2025
matheper
reviewed
Jul 24, 2025
matheper
reviewed
Jul 24, 2025
matheper
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes across multiple files, focusing on enhancing the analysis of agent behavior, simplifying the codebase, and removing obsolete functionality. The most significant updates include modifications to the
analysis/gather_results.py
file to improve data grouping and path extraction, the removal of the entire trajectory filtering module, and the addition of a new error handling case in thedebug_gym
environment.Enhancements to
analysis/gather_results.py
:map_uuid
function, simplifying the handling of UUIDs.path
field, enabling finer-grained analysis.path
anduuid
in the output.Removal of trajectory filtering module:
README.md
file for trajectory filtering, removing documentation for the module.criteria.py
file, which contained various filtering criteria for analyzing trajectories.filter.py
file, which implemented trajectory filtering logic and command-line tools.Updates to
debug_gym
environment:get_triggered_tools
to return a descriptive message when no tool call is generated by the agent.