Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spectre for debug builds #3914

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix spectre for debug builds #3914

merged 1 commit into from
Oct 1, 2024

Conversation

EricJohnson327
Copy link
Contributor

Summary of the pull request

  1. Make binskim only scan output directories. This fixes spectre failures in msvcrt debug binaries.
  2. Clean up spectre declarations in QuiteBackgroundProcesses ElevatedServer vcxproj.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@EricJohnson327 EricJohnson327 merged commit 13a8cc7 into main Oct 1, 2024
4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/ejohn/spectreFix branch October 1, 2024 17:38
@krschau krschau added this to the Dev Home v0.19 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krschau krschau krschau approved these changes

@guimafelipe guimafelipe guimafelipe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Dev Home v0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@EricJohnson327 @guimafelipe @krschau