Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Quiet Background Processes Experimental Feature #3962

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Remove Quiet Background Processes Experimental Feature #3962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
223da7b
Delete tools/QuietBackgroundProcesses
krschau Oct 31, 2024
a5fb2a0
Remove Quiet Background Process feature
krschau Oct 31, 2024
87fa55e
Remove DevHome.Telemetry.Native
krschau Oct 31, 2024
18a7def
Correct experimental features page typo
lauren-ciha Nov 7, 2024
2974a1a
Remove repo management page link
lauren-ciha Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 0 additions & 151 deletions DevHome.sln
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion settings/DevHome.Settings/DevHome.Settings.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@

<ItemGroup>
<ProjectReference Include="..\..\common\DevHome.Common.csproj" />
<ProjectReference Include="..\..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.ElevatedServer.Projection\DevHome.QuietBackgroundProcesses.ElevatedServer.Projection.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 1 addition & 9 deletions settings/DevHome.Settings/Strings/en-us/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,14 +545,6 @@
<value>View logs</value>
<comment>Click on this if you want to see Dev Home's logs on your machine.</comment>
</data>
<data name="QuietBackgroundProcessesExperiment_Name" xml:space="preserve">
<value>Quiet background processes</value>
<comment>Name of experimental feature 'Quiet background processes' on the 'Settings -&gt; Experiments' page where you enable it.</comment>
</data>
<data name="QuietBackgroundProcessesExperiment_Description" xml:space="preserve">
<value>Quiet background processes allows you to free up resources while developing</value>
<comment>Inline description of the Quiet background processes experimental feature on the 'Settings -&gt; Experiments' page where you enable it.</comment>
</data>
<data name="FileExplorerSourceControlIntegration_Name" xml:space="preserve">
<value>File Explorer Source Control Integration</value>
<comment>Name of experimental feature 'FileExplorer SourceControl Integration' on the 'Settings -&gt; Experiments' page where you enable it.</comment>
Expand All @@ -571,6 +563,6 @@
<value>Toggle to allow tester to change the source control provider.</value>
</data>
<data name="RepositoryManagementSourceControlSelector_Name" xml:space="preserve">
<value>Show Souce Control Provider</value>
<value>Show Source Control Provider</value>
</data>
</root>
13 changes: 0 additions & 13 deletions settings/DevHome.Settings/ViewModels/ExperimentalFeaturesViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using CommunityToolkit.Mvvm.ComponentModel;
using DevHome.Common.Models;
using DevHome.Common.Services;
using DevHome.QuietBackgroundProcesses;
using Microsoft.Internal.Windows.DevHome.Helpers.FileExplorer;

namespace DevHome.Settings.ViewModels;
Expand Down Expand Up @@ -39,18 +38,6 @@ public ExperimentalFeaturesViewModel(IExperimentationService experimentationServ
/// </summary>
private bool IsFeaturePresent(ExperimentalFeature experimentalFeature)
{
if (string.Equals(experimentalFeature.Id, "QuietBackgroundProcessesExperiment", StringComparison.OrdinalIgnoreCase))
{
try
{
return QuietBackgroundProcessesSessionManager.IsFeaturePresent();
}
catch (Exception)
{
return false;
}
}

if (string.Equals(experimentalFeature.Id, "FileExplorerSourceControlIntegration", StringComparison.OrdinalIgnoreCase))
{
try
Expand Down
28 changes: 0 additions & 28 deletions src/DevHome.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@
<ProjectReference Include="..\tools\Customization\DevHome.FileExplorerSourceControlIntegration\DevHome.FileExplorerSourceControlIntegration.csproj" />
<ProjectReference Include="..\tools\Dashboard\DevHome.Dashboard\DevHome.Dashboard.csproj" />
<ProjectReference Include="..\tools\Experiments\src\DevHome.Experiments.csproj" />
<ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.ElevatedServer.Projection\DevHome.QuietBackgroundProcesses.ElevatedServer.Projection.csproj" />
<ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.ElevatedServer\DevHome.QuietBackgroundProcesses.ElevatedServer.vcxproj" />
<ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine\DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine.vcxproj" />
<ProjectReference Include="..\tools\QuietBackgroundProcesses\DevHome.QuietBackgroundProcesses.Server\DevHome.QuietBackgroundProcesses.Server.vcxproj" />
<ProjectReference Include="..\tools\RepositoryManagement\DevHome.RepositoryManagement\DevHome.RepositoryManagement.csproj" />
<ProjectReference Include="..\tools\SetupFlow\DevHome.SetupFlow\DevHome.SetupFlow.csproj" />
<ProjectReference Include="..\tools\ExtensionLibrary\DevHome.ExtensionLibrary\DevHome.ExtensionLibrary.csproj" />
Expand Down Expand Up @@ -134,30 +130,6 @@
<HasPackageAndPublishMenu>true</HasPackageAndPublishMenu>
</PropertyGroup>

<!-- Quiet background processes bins -->
<PropertyGroup>
<_DevHomeInternal_CppPlatform>$(Platform)</_DevHomeInternal_CppPlatform>
<_DevHomeInternal_CppPlatform Condition="'$(Platform)' == 'x86'">Win32</_DevHomeInternal_CppPlatform>
<DevHomeInternal_Win32RuntimePath Condition="$(DevHomeInternal_Win32RuntimePath.EndsWith('native\\'))">$(DevHomeInternal_Win32RuntimePath)$(_DevHomeInternal_CppPlatform)\</DevHomeInternal_Win32RuntimePath>
</PropertyGroup>
<ItemGroup>
<Content Include="$(DevHomeInternal_Win32RuntimePath)Microsoft.Internal.Windows.DevHome.Helpers.QuietBackgroundProcesses.dll">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
<Content Include="$(CppBaseOutDir)\DevHome.QuietBackgroundProcesses.Server\DevHome.QuietBackgroundProcesses.Server.exe">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
<Content Include="$(CppBaseOutDir)\DevHome.QuietBackgroundProcesses.ElevatedServer\DevHome.QuietBackgroundProcesses.ElevatedServer.exe">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
<Content Include="$(CppBaseOutDir)\DevHome.QuietBackgroundProcesses.Common\DevHome.QuietBackgroundProcesses.winmd">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
<Content Include="$(CppBaseOutDir)\DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine\DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine.dll">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
</ItemGroup>

<!-- Third party notice file -->
<ItemGroup>
<Content Include="$(SolutionDir)NOTICE.txt">
Expand Down
30 changes: 1 addition & 29 deletions src/NavConfig.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,31 +55,6 @@
]
},
"experimentalFeatures": [
{
"identity": "QuietBackgroundProcessesExperiment",
"enabledByDefault": false,
"needsFeaturePresenceCheck": true,
"buildTypeOverrides": [
{
"buildType": "dev",
"enabledByDefault": true,
"visible": true
},
{
"buildType": "canary",
"enabledByDefault": true,
"visible": true
},
{
"buildType": "stable",
"enabledByDefault": false,
"visible": true
}
],
"openPage": {
"key": "DevHome.Customization.ViewModels.MainPageViewModel"
}
},
{
"identity": "FileExplorerSourceControlIntegration",
"enabledByDefault": false,
Expand Down Expand Up @@ -125,10 +100,7 @@
"enabledByDefault": false,
"visible": false
}
],
"openPage": {
"key": "DevHome.RepositoryManagement.ViewModels.RepositoryManagementMainPageView"
}
]
},
{
"identity": "RepositoryManagementSourceControlSelector",
Expand Down
17 changes: 0 additions & 17 deletions src/Package-Can.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,6 @@
<uap:SplashScreen Image="Assets\Logos\SplashScreen.png" />
</uap:VisualElements>
<Extensions>
<!-- QuietBackgroundProcesses unelevated server which initiates & obtains a reference to a quiet session -->
<uap5:Extension Category="windows.activatableClass.outOfProcessServer" uap10:TrustLevel="mediumIL" uap10:RuntimeBehavior="packagedClassicApp">
<uap5:OutOfProcessServer ServerName="DevHome.QuietBackgroundProcesses.Server" RunFullTrust="true">
<uap5:Path>DevHome.QuietBackgroundProcesses.Server.exe</uap5:Path>
<uap5:Instancing>singleInstance</uap5:Instancing>
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.QuietBackgroundProcessesSessionManager" />
</uap5:OutOfProcessServer>
</uap5:Extension>
<!-- QuietBackgroundProcesses elevated server owns the quiet session -->
<uap5:Extension Category="windows.activatableClass.outOfProcessServer" uap10:TrustLevel="mediumIL" uap10:RuntimeBehavior="packagedClassicApp">
<uap5:OutOfProcessServer ServerName="DevHome.QuietBackgroundProcesses.ElevatedServer" RunFullTrust="true">
<uap5:Path>DevHome.QuietBackgroundProcesses.ElevatedServer.exe</uap5:Path>
<uap5:Instancing>singleInstance</uap5:Instancing>
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.QuietBackgroundProcessesSession" />
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine" />
</uap5:OutOfProcessServer>
</uap5:Extension>
<uap3:Extension Category="windows.appExtensionHost">
<uap3:AppExtensionHost>
<uap3:Name>com.microsoft.devhome</uap3:Name>
Expand Down
17 changes: 0 additions & 17 deletions src/Package-Dev.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,6 @@
<uap:SplashScreen Image="Assets\Logos\SplashScreen.png" />
</uap:VisualElements>
<Extensions>
<!-- QuietBackgroundProcesses unelevated server which initiates & obtains a reference to a quiet session -->
<uap5:Extension Category="windows.activatableClass.outOfProcessServer" uap10:TrustLevel="mediumIL" uap10:RuntimeBehavior="packagedClassicApp">
<uap5:OutOfProcessServer ServerName="DevHome.QuietBackgroundProcesses.Server" RunFullTrust="true">
<uap5:Path>DevHome.QuietBackgroundProcesses.Server.exe</uap5:Path>
<uap5:Instancing>singleInstance</uap5:Instancing>
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.QuietBackgroundProcessesSessionManager" />
</uap5:OutOfProcessServer>
</uap5:Extension>
<!-- QuietBackgroundProcesses elevated server owns the quiet session -->
<uap5:Extension Category="windows.activatableClass.outOfProcessServer" uap10:TrustLevel="mediumIL" uap10:RuntimeBehavior="packagedClassicApp">
<uap5:OutOfProcessServer ServerName="DevHome.QuietBackgroundProcesses.ElevatedServer" RunFullTrust="true">
<uap5:Path>DevHome.QuietBackgroundProcesses.ElevatedServer.exe</uap5:Path>
<uap5:Instancing>singleInstance</uap5:Instancing>
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.QuietBackgroundProcessesSession" />
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine" />
</uap5:OutOfProcessServer>
</uap5:Extension>
<uap3:Extension Category="windows.appExtensionHost">
<uap3:AppExtensionHost>
<uap3:Name>com.microsoft.devhome</uap3:Name>
Expand Down
17 changes: 0 additions & 17 deletions src/Package.appxmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,6 @@
<uap:SplashScreen Image="Assets\Logos\SplashScreen.png" />
</uap:VisualElements>
<Extensions>
<!-- QuietBackgroundProcesses unelevated server which initiates & obtains a reference to a quiet session -->
<uap5:Extension Category="windows.activatableClass.outOfProcessServer" uap10:TrustLevel="mediumIL" uap10:RuntimeBehavior="packagedClassicApp">
<uap5:OutOfProcessServer ServerName="DevHome.QuietBackgroundProcesses.Server" RunFullTrust="true">
<uap5:Path>DevHome.QuietBackgroundProcesses.Server.exe</uap5:Path>
<uap5:Instancing>singleInstance</uap5:Instancing>
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.QuietBackgroundProcessesSessionManager" />
</uap5:OutOfProcessServer>
</uap5:Extension>
<!-- QuietBackgroundProcesses elevated server owns the quiet session -->
<uap5:Extension Category="windows.activatableClass.outOfProcessServer" uap10:TrustLevel="mediumIL" uap10:RuntimeBehavior="packagedClassicApp">
<uap5:OutOfProcessServer ServerName="DevHome.QuietBackgroundProcesses.ElevatedServer" RunFullTrust="true">
<uap5:Path>DevHome.QuietBackgroundProcesses.ElevatedServer.exe</uap5:Path>
<uap5:Instancing>singleInstance</uap5:Instancing>
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.QuietBackgroundProcessesSession" />
<uap5:ActivatableClass ActivatableClassId="DevHome.QuietBackgroundProcesses.PerformanceRecorderEngine" />
</uap5:OutOfProcessServer>
</uap5:Extension>
<uap3:Extension Category="windows.appExtensionHost">
<uap3:AppExtensionHost>
<uap3:Name>com.microsoft.devhome</uap3:Name>
Expand Down
4 changes: 0 additions & 4 deletions telemetry/DevHome.Telemetry.Native/DevHome.Telemetry.Native.targets
View file
Open in desktop

This file was deleted.

Loading
Loading