-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Database Support #1005
base: main
Are you sure you want to change the base?
Multi-Database Support #1005
Conversation
…into talzacc/multi_db
…into talzacc/multi_db
Some tiny nitpicking if it's not too early: A) Some more bounds checking can be done on the lower bound. B) SWAPDB doesn't update CLIENT LIST db field if the current connection's database is swapped. Also doesn't update the current database when called from lua inside the script context. C) Redis also adds a line for each db under 'Keyspace' in INFO command. |
Thanks @prvyk! Super helpful! |
In some cases the check is "db < -1" (and not db < 0). What is -1 supposed to mean when it's 'legal'?
I think I got confused with CLIENT LIST. The lua thing is this:
Redis ->
Garnet ->
(Afterwards, 'GET a' returns "2" with both) Redis seems to switch during the script context. |
…into talzacc/multi_db
-1 is the same as not specifying an ID (i.e. "save all etc."), I suppose I can just disable it from the input as to not cause confusion.
Good to know, I haven't tested SWAPDB from a LUA context, I'll add that to the tests as well! |
@prvyk fixed the Lua swap issue, let me know if you see anything else that needs attention :) Thanks again! |
This PR enables multiple logical databases in a single Garnet server instance.
This PR includes: