Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Azure Device Behavior for Non-Existent Files #1066

Conversation

priyanjgupta
Copy link
Contributor

@priyanjgupta priyanjgupta commented Mar 4, 2025

Issue Description:
The current recovery logic uses a double buffering scan for commits, causing the page the device is searching for to spill into the next segment, which may not exist. In such cases, the device repeatedly retries to find the non-existent file, resulting in a 90-second hang and eventually a "blob not found" error. This causes all subsequent read/write requests to be canceled under the current implementation. In contrast, the local device creates the file when it encounters a non-existent file. This PR aims to align the behavior between both device implementations.

Steps to reproduce the bug:
Start garnet server with following flags

"--cluster",
"--aof",
"--use-azure-storage",
"true",
"--storage-string",
"UseDevelopmentStorage=true",
"--recover",
"true",
"--aof-commit-freq",
"0",

After the blob not found error, subsequent writes should fail to commit.

Screenshots

image

Expected Behavior
image

@priyanjgupta priyanjgupta marked this pull request as ready for review March 5, 2025 04:38
@TalZaccai TalZaccai self-requested a review March 6, 2025 19:19
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits :)

@TalZaccai TalZaccai merged commit 111c0dd into microsoft:main Mar 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants