-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Garnet.Worker to win-x64-based-readytorun #1084
Open
darrenge
wants to merge
17
commits into
main
Choose a base branch
from
darrenge/GarnetWorkerRelease
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Service" folder. This required changes to the publishing file as well as create binaries powershell. NOTE - external release pipeline has the final release steps DISABLED so actual release doesn't happen when testing. However, testing code to only run the final push if on main
…et.Worker) doesn't get skipped.
…ipeline and not local. Maybe case sensitive issue with name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from a customer to add Garnet.Worker to the win-x64-based-readytorun.zip file. The main change was to the win-x64-based-readytorun.pubxml where I added the Garnet.Worker files to the "Service" folder.
The other change was to the release pipeline but that was mainly to put a check there that the actual push to Nuget and GitHub releases can only happen on Main. Can run everything else on another branch, but the final push can only happen on main. Just an extra safe guard that non main branches aren't being released.
The binaries ps1 file was specific to Garnet.Server (extra checks to double check Garnet.Server) so just small modification there