Add more test coverage for Tsavorite primitives #1121
Conversation
|
This may still be needed, as the MetadataSize check is different from Length check. A SpanByte may have an 8 byte optional header used for storing logical record expiration time (a bit tells us whether there is such a header). The MetadataSize check ensures that both left and right have such a metadata header. MetadataSize will be either 8 or 0, depending on this bit. |
|
Ah, thanks for explanation. I should have looked where that getter leads to before jumping to conclusion. 🤦♂️ I probably should pivot this PR to add tests to catch this detail, that the KeyComparer must be able to distinguish SpanBytes if their MetadataSizes are different. Bit spooky that the CI passed |
This reverts commit a2a9a81.
PaulusParssinen
changed the title
PaulusParssinen
changed the title
* Add disclaimer about this operation on platforms that don't support misaligned memory access
| [Test] | ||
| public void Equals_ReturnsTrue_ForEmptyAndInvalid() | ||
| { | ||
| var invalid = new SpanByte(); | ||
| invalid.Invalid = true; | ||
|
|
||
| var valid = new SpanByte(); | ||
|
|
||
| ClassicAssert.IsTrue(SpanByteComparer.Instance.Equals(ref invalid, ref valid)); | ||
| } |
There was a problem hiding this comment.
Thought to just show this here and ask whether it is intentional or leave it as "undefined" behaviour and we should not try make any contract in the tests?
|
Seems like unrelated flaky test failure. There is probably more to do in Tsavorite tests but this will do as a start. Suggestions for any interesting or important test cases to still implement in this PR are welcome 👍 |
|
Ted's large PR at #1186 might clash with this one. We were hoping to get that in without too many more clashes. Any chance this could be revised to work off of that branch? |
Sounds good, I can revisit this once that merges 👍 |
|
Thanks @PaulusParssinen , would also appreciate if you can review that PR #1186 (fine to review the draft, as the pending changes right now are focused on larger-than-memory modifications) -- as it makes a lot of the improvements that have been suggested by you and other .NET experts over the last year. |
Add little more
SpanByteand its associated comparison logic unit test coverage. Also contains some Tsavorite test code housekeeping (mostly doing switching to simpler UTF-8 logic instead of UTF-16).Follow up work
SpanBytespecific unit tests inTsavorite.test