Migrate Slots & Keys Optimizations #1217
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds following optimizations and fixes to migrate operations
NOTES:
Keys to be migrated are not known in advance. We have to scan the store log and capture the keys that belong to a specific slot. The problem with regular scanning is that we might miss keys that have been read-copy-updated to tail if we scan a fixed region.
The solution is to ScanCursor(BA, TA) and return all live keys that may exist beyond the TA address.
If we can do that and because we guarantee no new keys could be added beyond TA for the associated slot (because the slot is in MIGRATING state) then we guarantee that no keys are missed during migration.
The algorithm is as follows: